Permalink
Browse files

just kill brittle test

  • Loading branch information...
1 parent dc88847 commit c91912700d31f1f3b54192beefc6f5496804a396 @josh josh committed Mar 24, 2009
Showing with 0 additions and 21 deletions.
  1. +0 −21 actionpack/test/controller/session/cookie_store_test.rb
@@ -193,27 +193,6 @@ def test_persistent_session_id
end
end
- def test_session_store_with_expire_after
- app = ActionController::Session::CookieStore.new(DispatcherApp, :key => SessionKey, :secret => SessionSecret, :expire_after => 5.hours)
- @integration_session = open_session(app)
-
- with_test_route_set do
- # First request accesses the session
- cookies[SessionKey] = SignedBar
-
- get '/set_session_value'
- assert_response :success
- cookie = headers['Set-Cookie']
-
- # Second request does not access the session so the
- # expires header should not be changed
- get '/no_session_access'
- assert_response :success
- assert_equal cookie, headers['Set-Cookie'],
- "#{unmarshal_session(cookie).inspect} expected but was #{unmarshal_session(headers['Set-Cookie']).inspect}"
- end
- end
-
private
def with_test_route_set
with_routing do |set|

1 comment on commit c919127

Contributor

knzconnor commented on c919127 Apr 8, 2009

Perhaps it’s not brittle in the way you think it is? We’ve definitely seen some breakages of options being passed down into the rack middleware sessions that are being hard to track down, so cutting tests might not be helping.

Please sign in to comment.