Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
raise a pull full error when the connection pool is full and no conne…
…ction can be obtained
- Loading branch information
1 parent
b1ac881
commit cceabe0
Showing
2 changed files
with
28 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this commit, on my machine i start getting an error when running
$ bundle exec rake test_postgresql
in activerecord:
I do not get this error with
but on some later commits i do, but maybe it does not happen every time. On some of the later commits i get a message that "there are too many connections" for the same test file. Errors are in
test_remove_connection
andtest_remove_connection_for_thread
.Maybe it is something about my local settings, but this is just to let you know.
Happy New Year! I am off.
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are more details. This is what has just happened on my machine, from activerecord directory:
Same command again:
§ ARCONN=postgresql ruby -I test test/cases/connection_pool_test.rb ... 9 tests, 23 assertions, 0 failures, 0 errors, 0 skips
Like this 2 more times, then on the third time:
and on the fourth time:
In one of my previous experiments, i've also got another error:
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it happen against the tip?
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, starting from this commit, i always get either one or two errors
NoMethodError: undefined method 'close' for nil:NilClass
in those test cases when runningbundle exec rake test_postgresql
Last time just tried with 29f0f25.
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried again with the previous commit b1ac881, tests pass without errors.
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in 41be0fc
cceabe0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it passes with the latest 49b6b49!