Permalink
Browse files

Added .rvmrc to gitignore

  • Loading branch information...
amerine authored and josevalim committed Feb 21, 2011
1 parent 6c30530 commit cd12c369961a612f6b083fc0e3b877cf59b737f4
Showing with 1 addition and 0 deletions.
  1. +1 −0 .gitignore
View
@@ -20,3 +20,4 @@ railties/test/initializer/root/log
railties/doc
railties/guides/output
railties/tmp
+.rvmrc

4 comments on commit cd12c36

@tomstuart

This comment has been minimized.

Show comment Hide comment
@tomstuart

tomstuart Feb 21, 2011

Contributor

This should go in a global .gitignore (like .DS_Store etc), not the project's. See 5a8e728.

Contributor

tomstuart replied Feb 21, 2011

This should go in a global .gitignore (like .DS_Store etc), not the project's. See 5a8e728.

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim Feb 21, 2011

Contributor

We have discussed that in the pull request. As some people do share .rvmrc between projects (like rails apps), I have chosen to add it to Rails' .gitignore

Contributor

josevalim replied Feb 21, 2011

We have discussed that in the pull request. As some people do share .rvmrc between projects (like rails apps), I have chosen to add it to Rails' .gitignore

@tomstuart

This comment has been minimized.

Show comment Hide comment
@tomstuart

tomstuart Feb 21, 2011

Contributor

Thanks, I hadn't seen the pull request. I still disagree and think this sets a bad example (i.e. people who don't have .rvmrc in their global .gitignore are doing it wrong; they should explicitly git add -f it on a per-project basis if they want to share it) but don't feel strongly enough to argue!

Contributor

tomstuart replied Feb 21, 2011

Thanks, I hadn't seen the pull request. I still disagree and think this sets a bad example (i.e. people who don't have .rvmrc in their global .gitignore are doing it wrong; they should explicitly git add -f it on a per-project basis if they want to share it) but don't feel strongly enough to argue!

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim Feb 21, 2011

Contributor

Yeah, that was my thought but I did not feel strong enough to argue as well. :)

Contributor

josevalim replied Feb 21, 2011

Yeah, that was my thought but I did not feel strong enough to argue as well. :)

Please sign in to comment.