Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #5841 from oscardelben/rename_count_observers

Rename Observing#count_observers to Observing#observers_count
  • Loading branch information...
commit cd556c9388171bff263825d3066ef440a00d01b3 2 parents a837b30 + 27d6ccd
@josevalim josevalim authored
View
9 activemodel/lib/active_model/observing.rb
@@ -4,6 +4,7 @@
require 'active_support/core_ext/module/remove_method'
require 'active_support/core_ext/string/inflections'
require 'active_support/core_ext/enumerable'
+require 'active_support/deprecation'
require 'active_support/descendants_tracker'
module ActiveModel
@@ -74,10 +75,16 @@ def notify_observers(*args)
end
# Total number of observers.
- def count_observers
+ def observers_count
observer_instances.size
end
+ def count_observers
+ msg = "count_observers is deprecated in favor of observers_count"
+ ActiveSupport::Deprecation.warn(msg)
+ observers_count
+ end
+
protected
def instantiate_observer(observer) #:nodoc:
# string/symbol
View
2  activemodel/test/cases/observing_test.rb
@@ -73,7 +73,7 @@ def setup
test "passes observers to subclasses" do
FooObserver.instance
bar = Class.new(Foo)
- assert_equal Foo.count_observers, bar.count_observers
+ assert_equal Foo.observers_count, bar.observers_count
end
end
Please sign in to comment.
Something went wrong with that request. Please try again.