From 74563c63bdda08fdf1a026e908d51f536436c674 Mon Sep 17 00:00:00 2001 From: Eric Guo Date: Mon, 13 Jul 2015 13:09:59 +0800 Subject: [PATCH] Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug. --- lib/arel/visitors/oracle.rb | 2 +- test/visitors/test_oracle.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb index ff9e38d0500ac..875b0e5b6a6c7 100644 --- a/lib/arel/visitors/oracle.rb +++ b/lib/arel/visitors/oracle.rb @@ -17,7 +17,7 @@ def visit_Arel_Nodes_SelectStatement o, collector if o.limit && o.offset o = o.dup - limit = o.limit.expr.expr + limit = o.limit.expr offset = o.offset o.offset = nil collector << " diff --git a/test/visitors/test_oracle.rb b/test/visitors/test_oracle.rb index 41e77d93c000a..e9ed9d76b3a63 100644 --- a/test/visitors/test_oracle.rb +++ b/test/visitors/test_oracle.rb @@ -111,7 +111,7 @@ def compile node it 'creates a different subquery when there is an offset' do stmt = Nodes::SelectStatement.new - stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10)) + stmt.limit = Nodes::Limit.new(10) stmt.offset = Nodes::Offset.new(10) sql = compile stmt sql.must_be_like %{ @@ -126,7 +126,7 @@ def compile node it 'is idempotent with different subquery' do stmt = Nodes::SelectStatement.new - stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10)) + stmt.limit = Nodes::Limit.new(10) stmt.offset = Nodes::Offset.new(10) sql = compile stmt sql2 = compile stmt