From cec60d39891650c96f008aadcb49c249626da3f5 Mon Sep 17 00:00:00 2001 From: Guillermo Iguaran Date: Sun, 28 Aug 2016 00:37:10 -0500 Subject: [PATCH] validate_each in NumericalityValidator is never called in this case. NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate. --- activemodel/lib/active_model/validations/numericality.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/activemodel/lib/active_model/validations/numericality.rb b/activemodel/lib/active_model/validations/numericality.rb index af27955554d1b..48e0e5c9f63f8 100644 --- a/activemodel/lib/active_model/validations/numericality.rb +++ b/activemodel/lib/active_model/validations/numericality.rb @@ -26,8 +26,6 @@ def validate_each(record, attr_name, value) raw_value = value end - return if options[:allow_nil] && raw_value.nil? - unless is_number?(raw_value) record.errors.add(attr_name, :not_a_number, filtered_options(raw_value)) return