Permalink
Browse files

Keep index names when using with sqlite3

  • Loading branch information...
1 parent e68abc2 commit d01f913f8d21230b387c70d13b5646a838ba2915 @senny senny committed with senny Dec 15, 2012
@@ -1,5 +1,10 @@
## Rails 4.0.0 (unreleased) ##
+* Keep index names when using `alter_table` with sqlite3.
+ Fix #3489
+
+ *Yves Senn*
+
* Add ability for postgresql adapter to disable user triggers in disable_referential_integrity.
Fix #5523
@@ -537,7 +537,6 @@ def copy_table(from, to, options = {}) #:nodoc:
end
yield @definition if block_given?
end
-
copy_table_indexes(from, to, options[:rename] || {})
copy_table_contents(from, to,
@definition.columns.map {|column| column.name},
@@ -560,7 +559,7 @@ def copy_table_indexes(from, to, rename = {}) #:nodoc:
unless columns.empty?
# index name can't be the same
- opts = { :name => name.gsub(/_(#{from})_/, "_#{to}_") }
+ opts = { name: name.gsub(/(^|_)(#{from})_/, "\\1#{to}_") }
opts[:unique] = true if index.unique
add_index(to, columns, opts)
end
@@ -173,6 +173,16 @@ def test_change_column_with_new_default
refute TestModel.new.administrator?
end
+ def test_change_column_with_custom_index_name
+ add_column "test_models", "category", :string
+ add_index :test_models, :category, name: 'test_models_categories_idx'
+
+ assert_equal ['test_models_categories_idx'], connection.indexes('test_models').map(&:name)
+ change_column "test_models", "category", :string, null: false, default: 'article'
+
+ assert_equal ['test_models_categories_idx'], connection.indexes('test_models').map(&:name)
+ end
+
def test_change_column_default
add_column "test_models", "first_name", :string
connection.change_column_default "test_models", "first_name", "Tester"

0 comments on commit d01f913

Please sign in to comment.