Permalink
Browse files

Rewrite hm:t#create tests using assert_no_difference and assert_diffe…

…rence
  • Loading branch information...
1 parent ad28e00 commit d0f891ae0215d7963b3918f3847ee4c015a6b90c @lifo lifo committed Aug 10, 2009
Showing with 8 additions and 12 deletions.
  1. +8 −12 activerecord/test/cases/associations/has_many_through_associations_test.rb
@@ -180,27 +180,23 @@ def test_create_on_new_record
end
def test_associate_with_create_and_invalid_options
- peeps = companies(:first_firm).developers.count
- assert_nothing_raised { companies(:first_firm).developers.create(:name => '0') }
- assert_equal peeps, companies(:first_firm).developers.count
+ firm = companies(:first_firm)
+ assert_no_difference('firm.developers.count') { assert_nothing_raised { firm.developers.create(:name => '0') } }
end
def test_associate_with_create_and_valid_options
- peeps = companies(:first_firm).developers.count
- assert_nothing_raised { companies(:first_firm).developers.create(:name => 'developer') }
- assert_equal peeps + 1, companies(:first_firm).developers.count
+ firm = companies(:first_firm)
+ assert_difference('firm.developers.count', 1) { firm.developers.create(:name => 'developer') }
end
def test_associate_with_create_bang_and_invalid_options
- peeps = companies(:first_firm).developers.count
- assert_raises(ActiveRecord::RecordInvalid) { companies(:first_firm).developers.create!(:name => '0') }
- assert_equal peeps, companies(:first_firm).developers.count
+ firm = companies(:first_firm)
+ assert_no_difference('firm.developers.count') { assert_raises(ActiveRecord::RecordInvalid) { firm.developers.create!(:name => '0') } }
end
def test_associate_with_create_bang_and_valid_options
- peeps = companies(:first_firm).developers.count
- assert_nothing_raised { companies(:first_firm).developers.create!(:name => 'developer') }
- assert_equal peeps + 1, companies(:first_firm).developers.count
+ firm = companies(:first_firm)
+ assert_difference('firm.developers.count', 1) { firm.developers.create!(:name => 'developer') }
end
def test_clear_associations

0 comments on commit d0f891a

Please sign in to comment.