Permalink
Browse files

backport, handle trailing slash with engines

this is a backport of #8115 to fix #7842
  • Loading branch information...
senny committed Nov 4, 2012
1 parent 70f384e commit d12e75340996f174649ed584b062f46aa030e0dd
View
@@ -1,5 +1,10 @@
## Rails 3.2.10 (unreleased) ##
+* prevent double slashes in engine urls when `Rails.application.default_url_options[:trailing_slash] = true` is set
+ Fix #7842
+
+ *Yves Senn*
+
* Fix input name when `:multiple => true` and `:index` are set.
Before:
@@ -451,7 +451,7 @@ def define_generate_prefix(app, name)
# we must actually delete prefix segment keys to avoid passing them to next url_for
_route.segment_keys.each { |k| options.delete(k) }
prefix = _routes.url_helpers.send("#{name}_path", prefix_options)
- prefix = '' if prefix == '/'
+ prefix = prefix.gsub(%r{/\z}, '')
prefix
end
end
@@ -248,6 +248,11 @@ def setup
assert_equal "/something/", app_object.root_path
end
+ test "[OBJECT] generating application's route includes default_url_options[:trailing_slash]" do
+ RailsApplication.routes.default_url_options[:trailing_slash] = true
+ assert_equal "/awesome/blog/posts", engine_object.posts_path
+ end
+
test "[OBJECT] generating engine's route with url_for" do
path = engine_object.url_for(:controller => "inside_engine_generating",
:action => "show",

0 comments on commit d12e753

Please sign in to comment.