Skip to content
Browse files

Revert [6086] and [6087] since they caused a major regression with fu…

…nctional tests in 1.2.2. References #7372.

git-svn-id: http://svn-commit.rubyonrails.org/rails/branches/1-2-stable@6145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent ae11519 commit d1b93e7da26b12070ab3b4f75a1ed0b51139b3cc @jeremy jeremy committed Feb 10, 2007
View
2 actionpack/CHANGELOG
@@ -15,8 +15,6 @@
* Add singleton resources from trunk [Rick Olson]
-* TestSession supports indifferent access so session['foo'] == session[:foo] in your tests. #7372 [julik, jean.helou]
-
* select :multiple => true suffixes the attribute name with [] unless already suffixed. #6977 [nik.kakelin, ben, julik]
* Improve routes documentation. #7095 [zackchandler]
View
4 actionpack/lib/action_controller/test_process.rb
@@ -288,11 +288,11 @@ def data
end
def [](key)
- data[key.to_s]
+ data[key]
end
def []=(key, value)
- data[key.to_s] = value
+ data[key] = value
end
def update
View
14 actionpack/test/controller/test_test.rb
@@ -8,12 +8,6 @@ def set_flash
render :text => 'ignore me'
end
- def set_session
- session['string'] = 'A wonder'
- session[:symbol] = 'it works'
- render :text => 'Success'
- end
-
def render_raw_post
raise Test::Unit::AssertionFailedError, "#raw_post is blank" if request.raw_post.blank?
render :text => request.raw_post
@@ -117,14 +111,6 @@ def test_process_with_flash
assert_equal '>value<', flash['test']
end
- def test_process_with_session
- process :set_session
- assert_equal 'A wonder', session['string'], "A value stored in the session should be available by string key"
- assert_equal 'A wonder', session[:string], "Test session hash should allow indifferent access"
- assert_equal 'it works', session['symbol'], "Test session hash should allow indifferent access"
- assert_equal 'it works', session[:symbol], "Test session hash should allow indifferent access"
- end
-
def test_process_with_request_uri_with_no_params
process :test_uri
assert_equal "/test_test/test/test_uri", @response.body

0 comments on commit d1b93e7

Please sign in to comment.
Something went wrong with that request. Please try again.