Skip to content

Commit

Permalink
Require helpers so autoload is properly setup.
Browse files Browse the repository at this point in the history
  • Loading branch information
@josevalim
josevalim committed Jun 21, 2011
1 parent ceb5bbb commit d6f1291
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion actionpack/lib/sprockets/helpers/rails_helper.rb
View file
@@ -1,4 +1,4 @@
require "action_view/helpers/asset_tag_helper"
require "action_view/helpers"

This comment has been minimized.

Sign in to view

Copy link
@pixeltrix

pixeltrix Jul 1, 2011

Contributor

Shouldn't this just 'action_view' since ActionView::Helpers is autoloaded in action_view.rb

This comment has been minimized.

Sign in to view

Copy link
@josevalim

josevalim Jul 1, 2011

Author Contributor

Yup!

This comment has been minimized.

Sign in to view

Copy link
@josevalim

josevalim Jul 1, 2011

Author Contributor

Can you fix or should I fix it?

This comment has been minimized.

Sign in to view

Copy link
@pixeltrix

pixeltrix Jul 1, 2011

Contributor

I'm on the case

This comment has been minimized.

Sign in to view

Copy link
@pixeltrix

pixeltrix Jul 1, 2011

Contributor

Are we basically saying that no-one should be requiring anything other than 'action_view', because I know in the past I've pulled individual helpers into things like Liquid tags. You can include them, just don't require them - confirm?

This comment has been minimized.

Sign in to view

Copy link
@josevalim

josevalim Jul 1, 2011

Author Contributor

Yes, just requiring action_view in external libraries should be fine.

module Sprockets
module Helpers
Expand Down

0 comments on commit d6f1291

Please sign in to comment.