Permalink
Browse files

Fix HTML::Node to output double quotes instead of single quotes. Closes

#6845 [mitreandy]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 011f4e7 commit d833645cd8609e50f56acaaa7e6dd85e3198a446 @technoweenie technoweenie committed Dec 14, 2006
View
@@ -1,5 +1,7 @@
*SVN*
+* Fix HTML::Node to output double quotes instead of single quotes. Closes #6845 [mitreandy]
+
* Correctly report which filter halted the chain. #6699 [Martin Emde]
* Fix a bug in Routing where a parameter taken from the path of the current request could not be used as a query parameter for the next. Closes #6752. [Nicholas Seckar]
@@ -316,7 +316,7 @@ def to_s
s = "<#{@name}"
@attributes.each do |k,v|
s << " #{k}"
- s << "='#{v.gsub(/'/,"\\\\'")}'" if String === v
+ s << "=\"#{v}\"" if String === v
end
s << " /" if @closing == :self
s << ">"
@@ -204,7 +204,7 @@ def test_auto_link_with_block
def test_sanitize_form
raw = "<form action=\"/foo/bar\" method=\"post\"><input></form>"
result = sanitize(raw)
- assert_equal "&lt;form action='/foo/bar' method='post'><input>&lt;/form>", result
+ assert_equal %(&lt;form action="/foo/bar" method="post"><input>&lt;/form>), result
end
def test_sanitize_plaintext
@@ -216,25 +216,25 @@ def test_sanitize_plaintext
def test_sanitize_script
raw = "<script language=\"Javascript\">blah blah blah</script>"
result = sanitize(raw)
- assert_equal "&lt;script language='Javascript'>blah blah blah&lt;/script>", result
+ assert_equal %{&lt;script language="Javascript">blah blah blah&lt;/script>}, result
end
def test_sanitize_js_handlers
raw = %{onthis="do that" <a href="#" onclick="hello" name="foo" onbogus="remove me">hello</a>}
result = sanitize(raw)
- assert_equal %{onthis="do that" <a name='foo' href='#'>hello</a>}, result
+ assert_equal %{onthis="do that" <a name="foo" href="#">hello</a>}, result
end
def test_sanitize_javascript_href
raw = %{href="javascript:bang" <a href="javascript:bang" name="hello">foo</a>, <span href="javascript:bang">bar</span>}
result = sanitize(raw)
- assert_equal %{href="javascript:bang" <a name='hello'>foo</a>, <span>bar</span>}, result
+ assert_equal %{href="javascript:bang" <a name="hello">foo</a>, <span>bar</span>}, result
end
def test_sanitize_image_src
raw = %{src="javascript:bang" <img src="javascript:bang" width="5">foo</img>, <span src="javascript:bang">bar</span>}
result = sanitize(raw)
- assert_equal %{src="javascript:bang" <img width='5'>foo</img>, <span>bar</span>}, result
+ assert_equal %{src="javascript:bang" <img width="5">foo</img>, <span>bar</span>}, result
end
def test_cycle_class

0 comments on commit d833645

Please sign in to comment.