-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
- Loading branch information
There are no files selected for viewing
15 comments
on commit dad7fdc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! :D
I always wanted to see such commit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was my code ;-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do decide to remove plugins from Rails? Is there any explanation available? Please provide it.. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavelvasev you have an explaination here 853de2b#commitcomment-835327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Spastorino, thank you for fast reply!
The link you provide shows only one explanation: "vendor/plugins/* were on their way out with Rails 3.0, moving to gems instead. This is their last hurrah."
So actually we still have unanswered question - why plugins are moving out from Rails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's a newer/better way of developing plugins since 3.0 and doesn't worth to keep the old (2.3) way in Rails 4.0. @jeremy Can you explain it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavelvasev till now 2 versions of plugins needed to be maintained by rails team: vendor/plugins and regular gems (which can contain Railtie or Engine). If you want to simply extract a bunch of code to a plugin you can still easily do it, just generate a plugin somewhere in your app's dir, like
rails plugin new vendor/foo
and add it to gemfile like that:
gem 'foo', :path => "vendor/foo"
The second step (ie. adding line to a Gemfile) is done automatically if you create plugin somewhere inside app's directory on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to sum it up - it's still dead easy to have vendor/plugins functionality, but without any additional code, just using bundler. And you can quickly push such gem to rubygems without any changes (well, almost without any changes, you may need to set a few things in a gemspec).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drogus thanks for the help, my english sucks :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spastorino no problem :) and your english does not suck!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drogus it just took me 20 minutes to write two sentences :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spastorino @drogus Dear friends!
Thank you for your detailed reply!
So for our team as a users of Rails it matters that we still can ship some of "external" code within app, using gem :path => "
@drogus The only one is that I cannot understand:
The second step (ie. adding line to a Gemfile) is done automatically if you create plugin somewhere inside app's directory on master.
Can you explain the phraze "on master"?
Once again, thank you for explanations and for the job you do for all of the Rails worlds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavelvasev I meant that it works on edge rails (4.0.0.beta) from master branch at github
"Or" is not meaningful here anymore. And there is left a mention of plugins a few lines above.