Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

sub! can return nil

Revert "drop one more string allocation"

This reverts commit 4d15661.
  • Loading branch information...
commit daf226abc86557f1f48933a2fd56ee594478f528 1 parent 30526ac
@arunagw arunagw authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  actionview/lib/action_view/log_subscriber.rb
View
2  actionview/lib/action_view/log_subscriber.rb
@@ -30,7 +30,7 @@ def logger
EMPTY = ''
def from_rails_root(string)
- string.sub(rails_root, EMPTY).sub!(VIEWS_PATTERN, EMPTY)
+ string.sub(rails_root, EMPTY).sub(VIEWS_PATTERN, EMPTY)
end
def rails_root

2 comments on commit daf226a

@egilburg

Wouldn't it solvable by just returning string as the last method statement?

@rafaelfranca

:+1: I'll take a look

Please sign in to comment.
Something went wrong with that request. Please try again.