Permalink
Browse files

cleanup whitespace in relation.rb

  • Loading branch information...
senny committed May 13, 2013
1 parent ae6e6d9 commit db519c0c9a8d3d4f5afa2029408de5a860e037c1
Showing with 1 addition and 1 deletion.
  1. +1 βˆ’1 activerecord/lib/active_record/relation.rb
@@ -247,7 +247,7 @@ def size
def empty?
return @records.empty? if loaded?
- c = count
+ c = count(:all)
c.respond_to?(:zero?) ? c.zero? : c.empty?
end

4 comments on commit db519c0

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 1, 2013

Member

I think this commit message is wrong right?

Member

rafaelfranca replied Nov 1, 2013

I think this commit message is wrong right?

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Nov 2, 2013

Member

Judging from the commit message it looks very wrong! The strange part is, that I remember issues with count where we didn't specify :all. This was due to a refactoring on how count determined to column when select and stuff was involved.

After investigating I found that this line was already completely replaced. See 4ba9c50

Member

senny replied Nov 2, 2013

Judging from the commit message it looks very wrong! The strange part is, that I remember issues with count where we didn't specify :all. This was due to a refactoring on how count determined to column when select and stuff was involved.

After investigating I found that this line was already completely replaced. See 4ba9c50

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 4, 2013

Member

I see. I was investigating the failing tests on master and this is the first commit that introduced the failure and the commit message was very strange πŸ˜„. count(:all) or exists? are not working with polymorphic includes. I'm continue the investigation

Member

rafaelfranca replied Nov 4, 2013

I see. I was investigating the failing tests on master and this is the first commit that introduced the failure and the commit message was very strange πŸ˜„. count(:all) or exists? are not working with polymorphic includes. I'm continue the investigation

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Nov 4, 2013

Member

@rafaelfranca thanks and sorry for the confusion πŸ˜“

Member

senny replied Nov 4, 2013

@rafaelfranca thanks and sorry for the confusion πŸ˜“

Please sign in to comment.