Skip to content
Browse files

Deprecate plugin generator

  • Loading branch information...
1 parent 7344332 commit dc1250265cdf1ae4ab2d61b5d0b1cf2aa2f8ba0e @drogus drogus committed with josevalim Nov 14, 2010
View
7 railties/lib/rails/generators/rails/plugin/plugin_generator.rb
@@ -1,10 +1,17 @@
+
require 'rails/generators/rails/generator/generator_generator'
module Rails
module Generators
class PluginGenerator < NamedBase
class_option :tasks, :desc => "When supplied creates tasks base files."
+ def show_deprecation
+ return unless behavior == :invoke
+ message = "Plugin generator is depreacted, please use 'rails plugin new' command to generate plugin structure."
@tilsammans
tilsammans added a note Nov 15, 2010

s/depreacted/deprecated/g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ ActiveSupport::Deprecation.warn message
+ end
+
check_class_collision
def create_root_files
View
18 railties/test/generators/plugin_generator_test.rb
@@ -6,7 +6,7 @@ class PluginGeneratorTest < Rails::Generators::TestCase
arguments %w(plugin_fu)
def test_plugin_skeleton_is_created
- run_generator
+ silence(:stderr) { run_generator }
year = Date.today.year
%w(
@@ -36,30 +36,36 @@ def test_check_class_collision
end
def test_invokes_default_test_framework
- run_generator
+ silence(:stderr) { run_generator }
assert_file "vendor/plugins/plugin_fu/test/plugin_fu_test.rb", /class PluginFuTest < ActiveSupport::TestCase/
assert_file "vendor/plugins/plugin_fu/test/test_helper.rb"
end
def test_logs_if_the_test_framework_cannot_be_found
- content = run_generator ["plugin_fu", "--test-framework=rspec"]
+ content = nil
+ silence(:stderr) { content = run_generator ["plugin_fu", "--test-framework=rspec"] }
assert_match /rspec \[not found\]/, content
end
def test_creates_tasks_if_required
- run_generator ["plugin_fu", "--tasks"]
+ silence(:stderr) { run_generator ["plugin_fu", "--tasks"] }
assert_file "vendor/plugins/plugin_fu/lib/tasks/plugin_fu_tasks.rake"
end
def test_creates_generator_if_required
- run_generator ["plugin_fu", "--generator"]
+ silence(:stderr) { run_generator ["plugin_fu", "--generator"] }
assert_file "vendor/plugins/plugin_fu/lib/generators/templates"
assert_file "vendor/plugins/plugin_fu/lib/generators/plugin_fu_generator.rb",
/class PluginFuGenerator < Rails::Generators::NamedBase/
end
def test_plugin_generator_on_revoke
- run_generator
+ silence(:stderr) { run_generator }
run_generator ["plugin_fu"], :behavior => :revoke
end
+
+ def test_deprecation
+ output = capture(:stderr) { run_generator }
+ assert_match /Plugin generator is depreacted, please use 'rails plugin new' command to generate plugin structure./, output
+ end
end

0 comments on commit dc12502

Please sign in to comment.
Something went wrong with that request. Please try again.