Permalink
Browse files

Merge pull request #25609 from rosenfeld/patch-8

Add a Rails 5 release note for ActionController::Live becoming a Concern
  • Loading branch information...
eileencodes committed Jun 30, 2016
1 parent 8071152 commit dec4265a07825b2674d4d2ed0948f2aa7fbd64b7
Showing with 11 additions and 0 deletions.
  1. +11 −0 guides/source/5_0_release_notes.md
@@ -448,6 +448,17 @@ Please refer to the [Changelog][action-pack] for detailed changes.
`stale?`.
([Pull Request](https://github.com/rails/rails/pull/18374))
+* `ActionController::Live` became an `ActiveSupport::Concern`. That
+ means it can't be just included in other modules without extending
+ them with `ActiveSupport::Concern` or `ActionController::Live`
+ won't take effect in production. Some people may be using another
+ module to include some special `Warden`/`Devise` authentication
+ failure handling code as well since the middleware can't catch a
+ `:warden` thrown by a spawned thread which is the case when using
+ `ActionController::Live`.
+ ([More details in this issue](https://github.com/rails/rails/issues/25581))
+
+
Action View
-------------

0 comments on commit dec4265

Please sign in to comment.