Permalink
Browse files

Added the possibility of using symbols in addition to concrete classe…

…s with ActiveRecord::Observer#observe #3998 [robbyrussell/tarmo]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 94d7633 commit e38ad5ddcc1de38ff485d3d78d9c72283320cdaf @dhh dhh committed Sep 22, 2007
Showing with 7 additions and 3 deletions.
  1. +2 −0 activerecord/CHANGELOG
  2. +5 −3 activerecord/lib/active_record/observer.rb
@@ -1,5 +1,7 @@
*SVN*
+* Added the possibility of using symbols in addition to concrete classes with ActiveRecord::Observer#observe #3998 [robbyrussell/tarmo]
+
* Added ActiveRecord::Base#to_json/from_json (currently does not support :include like to_xml) [DHH]
* Added ActiveRecord::Base#from_xml [DHH]. Example:
@@ -84,10 +84,11 @@ def inherited(subclass)
#
# Observers will by default be mapped to the class with which they share a name. So CommentObserver will
# be tied to observing Comment, ProductManagerObserver to ProductManager, and so on. If you want to name your observer
- # differently than the class you're interested in observing, you can use the Observer.observe class method:
+ # differently than the class you're interested in observing, you can use the Observer.observe class method which takes
+ # either the concrete class (Product) or a symbol for that class (:product):
#
# class AuditObserver < ActiveRecord::Observer
- # observe Account
+ # observe :account
#
# def after_update(account)
# AuditTrail.new(account, "UPDATED")
@@ -97,7 +98,7 @@ def inherited(subclass)
# If the audit observer needs to watch more than one kind of object, this can be specified with multiple arguments:
#
# class AuditObserver < ActiveRecord::Observer
- # observe Account, Balance
+ # observe :account, :balance
#
# def after_update(record)
# AuditTrail.new(record, "UPDATED")
@@ -130,6 +131,7 @@ class Observer
class << self
# Attaches the observer to the supplied model classes.
def observe(*models)
+ models.flatten.collect! { |model| model.is_a?(Symbol) ? model.to_s.camelize.constantize : model }
define_method(:observed_classes) { Set.new(models) }
end

0 comments on commit e38ad5d

Please sign in to comment.