Permalink
Browse files

Quote these dates to prevent intermittent test failure. Suppose local…

… time is 00:50 GMT+1. Without the quoting, the YAML parser would parse this as 00:50 UTC, into the local time of 01:50 GMT+1. Then, it would get written into the database in local time as 01:50. When it came back out the UTC date from the database and the UTC date of two weeks ago would be compared. The former would be 23:50, and the latter would be 00:50, so the two dates would differ, causing the assertion to fail. Quoting it prevents the YAML parser from getting involved.
  • Loading branch information...
1 parent a173bb3 commit e42c544920ed679f6b4ee21f77d5e1c2fd49d582 @jonleighton jonleighton committed Aug 3, 2011
Showing with 2 additions and 2 deletions.
  1. +2 −2 activerecord/test/fixtures/pirates.yml
@@ -5,5 +5,5 @@ blackbeard:
redbeard:
catchphrase: "Avast!"
parrot: louis
- created_on: <%= 2.weeks.ago.to_s(:db) %>
- updated_on: <%= 2.weeks.ago.to_s(:db) %>
+ created_on: "<%= 2.weeks.ago.to_s(:db) %>"
+ updated_on: "<%= 2.weeks.ago.to_s(:db) %>"

0 comments on commit e42c544

Please sign in to comment.