Browse files

Address a failure test_remove_column_with_multi_column_index with Ora…

…cle database

Not only PostgreSQL, Oracle database adapter drops the multi-column index
if any of the indexed columns dropped by remove_column.
  • Loading branch information...
yahonda committed Jan 1, 2013
1 parent 5f63816 commit e7ff765e116600f85fd3bb68e6e9a5a5cbaef04d
Showing with 3 additions and 2 deletions.
  1. +3 −2 activerecord/test/cases/migration/rename_column_test.rb
@@ -107,8 +107,9 @@ def test_remove_column_with_multi_column_index
assert_equal 1, connection.indexes('test_models').size
remove_column("test_models", "hat_size")
- # FIXME: should all adapters behave the same?
- if current_adapter?(:PostgreSQLAdapter)
+ # Every database and/or database adapter has their own behavior
+ # if it drops the multi-column index when any of the indexed columns dropped by remove_column.
+ if current_adapter?(:PostgreSQLAdapter, :OracleAdapter)
assert_equal [], connection.indexes('test_models').map(&:name)
assert_equal ['index_test_models_on_hat_style_and_hat_size'], connection.indexes('test_models').map(&:name)

0 comments on commit e7ff765

Please sign in to comment.