Permalink
Browse files

Nobody sucks so nobody should call this awful method name

  • Loading branch information...
rafaelfranca committed Aug 12, 2014
1 parent 9424b48 commit e81f3c210eca074ed6227bd1c40835d44761c09e
@@ -55,4 +55,4 @@ def jruby_skip(message = '')
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.my_tests_are_order_dependent!
@@ -501,4 +501,4 @@ def shutdown
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.my_tests_are_order_dependent!
@@ -344,4 +344,4 @@ def jruby_skip(message = '')
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.my_tests_are_order_dependent!
@@ -17,4 +17,4 @@
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.my_tests_are_order_dependent!
@@ -205,4 +205,4 @@ def in_time_zone(zone)
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.tests_are_order_dependent!

This comment has been minimized.

Show comment
Hide comment
@andrewhr

andrewhr Aug 12, 2014

Little typo here, didn't? Everywhere in this PR you are using my_tests_are_order_dependent!

@andrewhr

andrewhr Aug 12, 2014

Little typo here, didn't? Everywhere in this PR you are using my_tests_are_order_dependent!

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 12, 2014

Member

Yes. I already fixed in a later commit

@rafaelfranca

rafaelfranca Aug 12, 2014

Member

Yes. I already fixed in a later commit

@@ -1,6 +1,6 @@
* Fix ActiveSupport::TestCase not to order users' test cases by default.
If this change breaks your tests because your tests are order dependent, you need to explicitly call
- ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! at the top of your tests.
+ ActiveSupport::TestCase.my_tests_are_order_dependent! at the top of your tests.
*Akira Matsuda*
@@ -15,6 +15,10 @@ module ActiveSupport
class TestCase < ::Minitest::Test
Assertion = Minitest::Assertion
+ class << self
+ alias :my_tests_are_order_dependent! :i_suck_and_my_tests_are_order_dependent!
+ end
+

This comment has been minimized.

Show comment
Hide comment
@jeremy

jeremy Aug 12, 2014

Member

Thank you @rafaelfranca! This commit = 😁👍

@jeremy

jeremy Aug 12, 2014

Member

Thank you @rafaelfranca! This commit = 😁👍

alias_method :method_name, :name
include ActiveSupport::Testing::TaggedLogging
@@ -42,4 +42,4 @@ def jruby_skip(message = '')
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
-ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
+ActiveSupport::TestCase.my_tests_are_order_dependent!
@@ -30,7 +30,7 @@ def jruby_skip(message = '')
class ActiveSupport::TestCase
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
- self.i_suck_and_my_tests_are_order_dependent!
+ self.my_tests_are_order_dependent!
private

25 comments on commit e81f3c2

@jaimerson

This comment has been minimized.

Show comment
Hide comment

👍

@soundarapandian

This comment has been minimized.

Show comment
Hide comment
@soundarapandian

soundarapandian Aug 12, 2014

This shows the attitude of a real Rails developer 👍

This shows the attitude of a real Rails developer 👍

@carloslopes

This comment has been minimized.

Show comment
Hide comment

👍

@rsl

This comment has been minimized.

Show comment
Hide comment
@rsl

rsl Aug 12, 2014

Contributor

love this

Contributor

rsl replied Aug 12, 2014

love this

@MSch

This comment has been minimized.

Show comment
Hide comment
@MSch

MSch Aug 12, 2014

Contributor

❤️💚💙💛💜

Contributor

MSch replied Aug 12, 2014

❤️💚💙💛💜

@andrewhr

This comment has been minimized.

Show comment
Hide comment
@andrewhr

andrewhr Aug 12, 2014

Nice like a delicious 🍨 :-)

Nice like a delicious 🍨 :-)

@jvanbaarsen

This comment has been minimized.

Show comment
Hide comment
@jvanbaarsen

jvanbaarsen Aug 12, 2014

Contributor

❤️

Contributor

jvanbaarsen replied Aug 12, 2014

❤️

@felipecsl

This comment has been minimized.

Show comment
Hide comment

I'm proud @rafaelfranca 👏

@coleww

This comment has been minimized.

Show comment
Hide comment

👍

@gbonfant

This comment has been minimized.

Show comment
Hide comment

😄 👍

@davidelbe

This comment has been minimized.

Show comment
Hide comment
@davidelbe

davidelbe Aug 12, 2014

I like this. 👍

I like this. 👍

@nettofarah

This comment has been minimized.

Show comment
Hide comment
@nettofarah

nettofarah Aug 12, 2014

Contributor

well done, man!

Contributor

nettofarah replied Aug 12, 2014

well done, man!

@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Aug 12, 2014

Contributor

Thanks for this @rafaelfranca!

Contributor

deivid-rodriguez replied Aug 12, 2014

Thanks for this @rafaelfranca!

@developersoul

This comment has been minimized.

Show comment
Hide comment

Thanks +1

@mkdynamic

This comment has been minimized.

Show comment
Hide comment
@mkdynamic

mkdynamic Aug 13, 2014

Contributor

Remember comedy?

Contributor

mkdynamic replied Aug 13, 2014

Remember comedy?

@splattael

This comment has been minimized.

Show comment
Hide comment
@splattael

splattael Aug 13, 2014

Contributor

👍 Thank you so much for being polite to users! :)

In seattlerb/minitest#400 @phiggins suggested an alternative:

def self.test_order
  :alpha
end
Contributor

splattael replied Aug 13, 2014

👍 Thank you so much for being polite to users! :)

In seattlerb/minitest#400 @phiggins suggested an alternative:

def self.test_order
  :alpha
end
@jnbt

This comment has been minimized.

Show comment
Hide comment

jnbt replied Aug 13, 2014

👍

@rrrene

This comment has been minimized.

Show comment
Hide comment

👍

@dustinboling

This comment has been minimized.

Show comment
Hide comment
@dustinboling

dustinboling Aug 13, 2014

👍 Awesome.

👍 Awesome.

@daxadax

This comment has been minimized.

Show comment
Hide comment

👍

@mikecmpbll

This comment has been minimized.

Show comment
Hide comment

👎

@danielkummer

This comment has been minimized.

Show comment
Hide comment

👍

@talbright

This comment has been minimized.

Show comment
Hide comment
@talbright

talbright Mar 19, 2015

Nice karma play 🙏

Nice karma play 🙏

@teknull

This comment has been minimized.

Show comment
Hide comment
@teknull

teknull Mar 19, 2015

Good to know the community has a sense of humor.

Good to know the community has a sense of humor.

@keepcosmos

This comment has been minimized.

Show comment
Hide comment
@keepcosmos

keepcosmos Mar 19, 2015

Contributor

👍

Contributor

keepcosmos replied Mar 19, 2015

👍

Please sign in to comment.