Permalink
Browse files

Merge pull request #8355 from steveklabnik/update_7418

Ensure that associations have a symbol argument.
  • Loading branch information...
2 parents 4c99d08 + 22df38c commit e9df07870fc16eaefbff60e0e80921489eefcd91 @rafaelfranca rafaelfranca committed Nov 28, 2012
@@ -1,5 +1,7 @@
## Rails 4.0.0 (unreleased) ##
+* Ensure that associations take a symbol argument. *Steve Klabnik*
+
* Fix dirty attribute checks for `TimeZoneConversion` with nil and blank
datetime attributes. Setting a nil datetime to a blank string should not
result in a change being flagged. Fix #8310
@@ -13,6 +13,8 @@ def self.build(*args, &block)
end
def initialize(model, name, scope, options)
+ raise ArgumentError, "association names must be a Symbol" unless name.kind_of?(Symbol)
+
@model = model
@name = name
@@ -289,6 +289,14 @@ def test_has_one_association_redefinition_reflections_should_differ_and_not_inhe
DifferentPeopleList.reflect_on_association(:has_one)
)
end
+
+ def test_requires_symbol_argument
+ assert_raises ArgumentError do
+ Class.new(Post) do
+ belongs_to "author"
+ end
+ end
+ end
end
class GeneratedMethodsTest < ActiveRecord::TestCase

0 comments on commit e9df078

Please sign in to comment.