Skip to content
This repository
Browse code

Add jruby-openssl gem in Gemfile necessary for JRuby

[#5762 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  • Loading branch information...
commit ea30da30699f588bee4dc4713859fe035d6243db 1 parent 1e63a05
Anil Wadghule authored October 06, 2010 spastorino committed October 07, 2010

Showing 1 changed file with 2 additions and 0 deletions. Show diff stats Hide diff stats

  1. 2  Gemfile
2  Gemfile
@@ -55,6 +55,8 @@ platforms :jruby do
55 55
 
56 56
   gem "activerecord-jdbcsqlite3-adapter"
57 57
 
  58
+  gem "jruby-openssl"
  59
+
58 60
   group :db do
59 61
     gem "activerecord-jdbcmysql-adapter"
60 62
     gem "activerecord-jdbcpostgresql-adapter"

0 notes on commit ea30da3

Xavier Noria

Albeit the rest of dependencies are clear, this one is not in my view. I think it would be good to add a comment

# Needed because Active Resource does such and such stuff.

or whatever.

Santiago Pastorino

Xavier, this is temporary, I've talked with Nick Sieger and we agreed to add it until JRuby merge jruby-openssl package in jruby package.
But now the problem is that you can't bundle install using JRuby if Gemfile doesn't have this line.
I will push a comment saying that ;).

Xavier Noria

There's some misunderstanding somewhere. Anil said in the ticket he could bundle install without the library, is that correct Anil?

Santiago Pastorino

Xavier yeah he said that he couldn't run some tests without this. Anyways JRuby needs this package to work with Rails so until they merge the jruby-openssl this could be in

Xavier Noria

Absolutely, but if bundle install works the comment cannot say this is needed for bundle install to work. See what I mean?

Xavier Noria

cool :)

Please sign in to comment.
Something went wrong with that request. Please try again.