Permalink
Browse files

Add jruby-openssl gem in Gemfile necessary for JRuby

[#5762 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  • Loading branch information...
1 parent 1e63a05 commit ea30da30699f588bee4dc4713859fe035d6243db @anildigital anildigital committed with spastorino Oct 6, 2010
Showing with 2 additions and 0 deletions.
  1. +2 −0 Gemfile
View
@@ -55,6 +55,8 @@ platforms :jruby do
gem "activerecord-jdbcsqlite3-adapter"
+ gem "jruby-openssl"
@fxn
fxn Oct 7, 2010 Ruby on Rails member

Albeit the rest of dependencies are clear, this one is not in my view. I think it would be good to add a comment

# Needed because Active Resource does such and such stuff.

or whatever.

@spastorino
spastorino Oct 7, 2010 Ruby on Rails member

Xavier, this is temporary, I've talked with Nick Sieger and we agreed to add it until JRuby merge jruby-openssl package in jruby package.
But now the problem is that you can't bundle install using JRuby if Gemfile doesn't have this line.
I will push a comment saying that ;).

@fxn
fxn Oct 7, 2010 Ruby on Rails member

There's some misunderstanding somewhere. Anil said in the ticket he could bundle install without the library, is that correct Anil?

@spastorino
spastorino Oct 7, 2010 Ruby on Rails member

Xavier yeah he said that he couldn't run some tests without this. Anyways JRuby needs this package to work with Rails so until they merge the jruby-openssl this could be in

@fxn
fxn Oct 7, 2010 Ruby on Rails member

Absolutely, but if bundle install works the comment cannot say this is needed for bundle install to work. See what I mean?

@spastorino
spastorino Oct 7, 2010 Ruby on Rails member
@fxn
fxn Oct 7, 2010 Ruby on Rails member

cool :)

+
group :db do
gem "activerecord-jdbcmysql-adapter"
gem "activerecord-jdbcpostgresql-adapter"

0 comments on commit ea30da3

Please sign in to comment.