Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add jruby-openssl gem in Gemfile necessary for JRuby

[#5762 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  • Loading branch information...
commit ea30da30699f588bee4dc4713859fe035d6243db 1 parent 1e63a05
Anil Wadghule anildigital authored spastorino committed
Showing with 2 additions and 0 deletions.
  1. +2 −0  Gemfile
2  Gemfile
View
@@ -55,6 +55,8 @@ platforms :jruby do
gem "activerecord-jdbcsqlite3-adapter"
+ gem "jruby-openssl"
Xavier Noria Owner
fxn added a note

Albeit the rest of dependencies are clear, this one is not in my view. I think it would be good to add a comment

# Needed because Active Resource does such and such stuff.

or whatever.

Santiago Pastorino Owner

Xavier, this is temporary, I've talked with Nick Sieger and we agreed to add it until JRuby merge jruby-openssl package in jruby package.
But now the problem is that you can't bundle install using JRuby if Gemfile doesn't have this line.
I will push a comment saying that ;).

Xavier Noria Owner
fxn added a note

There's some misunderstanding somewhere. Anil said in the ticket he could bundle install without the library, is that correct Anil?

Santiago Pastorino Owner

Xavier yeah he said that he couldn't run some tests without this. Anyways JRuby needs this package to work with Rails so until they merge the jruby-openssl this could be in

Xavier Noria Owner
fxn added a note

Absolutely, but if bundle install works the comment cannot say this is needed for bundle install to work. See what I mean?

Santiago Pastorino Owner
Xavier Noria Owner
fxn added a note

cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
group :db do
gem "activerecord-jdbcmysql-adapter"
gem "activerecord-jdbcpostgresql-adapter"
Xavier Noria
Owner

Albeit the rest of dependencies are clear, this one is not in my view. I think it would be good to add a comment

# Needed because Active Resource does such and such stuff.

or whatever.

Santiago Pastorino
Owner

Xavier, this is temporary, I've talked with Nick Sieger and we agreed to add it until JRuby merge jruby-openssl package in jruby package.
But now the problem is that you can't bundle install using JRuby if Gemfile doesn't have this line.
I will push a comment saying that ;).

Xavier Noria
Owner

There's some misunderstanding somewhere. Anil said in the ticket he could bundle install without the library, is that correct Anil?

Santiago Pastorino
Owner

Xavier yeah he said that he couldn't run some tests without this. Anyways JRuby needs this package to work with Rails so until they merge the jruby-openssl this could be in

Xavier Noria
Owner

Absolutely, but if bundle install works the comment cannot say this is needed for bundle install to work. See what I mean?

Xavier Noria
Owner

cool :)

Please sign in to comment.
Something went wrong with that request. Please try again.