Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Use Set instead of Array to speed up prototype helper include? calls.…

… Closes #2880.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit eb1dd6a2067be548ebd4328c390d91e5abc6d81d 1 parent 745ea39
@jeremy jeremy authored
View
2  actionpack/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Use Set instead of Array to speed up prototype helper include? calls. #2880 [Stefan Kaes]
+
* MemCache store may be given multiple addresses. #2869 [Ryan Carver <ryan@fivesevensix.com>]
* Handle cookie parsing irregularity for certain Nokia phones. #2530 [zaitzow@gmail.com]
View
12 actionpack/lib/action_view/helpers/prototype_helper.rb
@@ -1,4 +1,5 @@
require File.dirname(__FILE__) + '/javascript_helper'
+require 'set'
module ActionView
module Helpers
@@ -25,11 +26,12 @@ module Helpers
# on the page in an Ajax response.
module PrototypeHelper
unless const_defined? :CALLBACKS
- CALLBACKS = [ :uninitialized, :loading, :loaded, :interactive,
- :complete, :failure, :success ] + (100..599).to_a
- AJAX_OPTIONS = [ :before, :after, :condition, :url, :asynchronous,
- :method, :insertion, :position, :form, :with, :update,
- :script ] + CALLBACKS
+ CALLBACKS = Set.new([ :uninitialized, :loading, :loaded,
+ :interactive, :complete, :failure, :success ] +
+ (100..599).to_a)
+ AJAX_OPTIONS = Set.new([ :before, :after, :condition, :url,
+ :asynchronous, :method, :insertion, :position,
+ :form, :with, :update, :script ]).merge(CALLBACKS)
end
# Returns a link to a remote action defined by <tt>options[:url]</tt>
Please sign in to comment.
Something went wrong with that request. Please try again.