Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

to_sentence returns self[0].to_s instead of just self[0] for arrays o…

…f length 1. Closes #10390 [Chu Yeow, mrj]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit ef57b93a82acab5a79620e405af5534cdf0e89c3 1 parent 77de690
@jeremy jeremy authored
View
2  activesupport/lib/active_support/core_ext/array/conversions.rb
@@ -16,7 +16,7 @@ def to_sentence(options = {})
when 0
""
when 1
- self[0]
+ self[0].to_s
when 2
"#{self[0]} #{options[:connector]}#{self[1]}"
else
View
4 activesupport/test/core_ext/array_ext_test.rb
@@ -33,7 +33,6 @@ def test_plain_array_to_sentence
assert_equal "one", ['one'].to_sentence
assert_equal "one and two", ['one', 'two'].to_sentence
assert_equal "one, two, and three", ['one', 'two', 'three'].to_sentence
-
end
def test_to_sentence_with_connector
@@ -57,6 +56,9 @@ def test_one_element
assert_equal "one", ['one'].to_sentence
end
+ def test_one_non_string_element
+ assert_equal '1', [1].to_sentence
+ end
end
class ArrayExtToSTests < Test::Unit::TestCase
Please sign in to comment.
Something went wrong with that request. Please try again.