Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

@target might be nil when Identity Map is enabled.

* With Identity Map enabled, NameError might be raised and @target is
  nil. So we should always ensure `@target ||= find_target`.

* Only force reload target when it is stale.
  • Loading branch information...
commit f01f03e96390fb493830337571de578241619d4f 1 parent 9bd5c86
@larrylv larrylv authored
Showing with 8 additions and 3 deletions.
  1. +8 −3 activerecord/lib/active_record/associations/association.rb
View
11 activerecord/lib/active_record/associations/association.rb
@@ -129,8 +129,11 @@ def target_scope
# This method is abstract in the sense that it relies on +find_target+,
# which is expected to be provided by descendants.
#
- # If the \target is already \loaded it is just returned. Thus, you can call
- # +load_target+ unconditionally to get the \target.
+ # If the \target is stale(the target no longer points to the record(s) that the
+ # relevant foreign_key(s) refers to.), force reload the \target.
+ #
+ # Otherwise if the \target is already \loaded it is just returned. Thus, you can
+ # call +load_target+ unconditionally to get the \target.
#
# ActiveRecord::RecordNotFound is rescued within the method, and it is
# not reraised. The proxy is \reset and +nil+ is the return value.
@@ -139,11 +142,13 @@ def load_target
begin
if IdentityMap.enabled? && association_class && association_class.respond_to?(:base_class)
@target = IdentityMap.get(association_class, owner[reflection.foreign_key])
- else
+ elsif @stale_state && stale_target?
@target = find_target
end
rescue NameError
nil
+ ensure
+ @target ||= find_target
end
end
loaded! unless loaded?
Please sign in to comment.
Something went wrong with that request. Please try again.