Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Replace snowman with utf8=✓

  • Loading branch information...
commit f2d22ecbb3c63a8197fa5a34d4488bc320952db1 1 parent 1c970b8
@wycats wycats authored
View
2  actionpack/lib/action_view/helpers/form_tag_helper.rb
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
- :name => "_e", :value => "☃".html_safe)
+ :name => "utf8", :value => "✓".html_safe)
method = html_options.delete("method").to_s
View
2  actionpack/test/template/form_helper_test.rb
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
View
2  actionpack/test/template/form_tag_helper_test.rb
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

7 comments on commit f2d22ec

@fredwu

RIP, snowman! ;(

@radar

One day we built a snowman,
We built him out of snow;
You should have seen how fine he was,
All white from top to toe.

We poured some water over him,
To freeze his legs and ears;
And when we went indoors to bed,
We thought he'd last for years.

But, in the night a warmer kind
Of wind began to blow;
And Jack Frost cried and ran away,
And with him went the snow.

When we went out next morning
To bid our friend "Good Day",
There wasn't any snowman there...
He'd melted right away!

RIP Snowman :(

@d-snp

Sorry to join the discussion so late when it's already been changed 3 times, but why did you drop the underscore prefix? Isn't it convention to prefix system stuff with underscores so there's no chance of collision with the user defined parameters?

@Aupajo

8/12 Never forget.

@plukevdh

he made reading the logs so much more enjoyable...

Please sign in to comment.
Something went wrong with that request. Please try again.