Permalink
Show file tree
Hide file tree
11 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered making this the default in Bundler instead of the initial Rails app generator? This may cause unexpected behavior for those new to Rails - where they have binstubs initially but subsequent calls to bundle install/update doesn't refresh them or add new ones.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensie that's not how bundler works. The flag passed to install will be remembered, and later calls to install or update will update the binstubs.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensie we can't make it the default in bundler because some project (especially gems) have their own
bindirectories, which would be clobbered.f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indirect @wycats Makes sense. Remembering the flag passed to install sounds great. Is that part a Rails or Bundler thing?
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensie is part of Bundler.
Also we can update docs to tell to developers that they may want to use
bundle install --binstubsinstead ofbundle installthe first time they checkout a Rails project from VCS.f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most projects should just checkin the bin stubs.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhh Commit 35c554f encourages the opposite.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with checking in binstubs in general is that the shebang line is system specific (special for windows, rbenv) so your team would need to have a very consistent setup to avoid problems.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f34c27aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.