Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Don't alter the Hash passed to attributes=, closes #3385

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit f41feb349caed7580ba0493e3bb2e393cdb45ddb 1 parent f9e0ba2
@NZKoz NZKoz authored
View
5 activerecord/lib/active_record/base.rb
@@ -1334,8 +1334,9 @@ def []=(attr_name, value)
# from this form of mass-assignment by using the +attr_protected+ macro. Or you can alternatively
# specify which attributes *can* be accessed in with the +attr_accessible+ macro. Then all the
# attributes not included in that won't be allowed to be mass-assigned.
- def attributes=(attributes)
- return if attributes.nil?
+ def attributes=(attrs)
+ return if attrs.nil?
+ attributes= attrs.dup
attributes.stringify_keys!
multi_parameter_attributes = []
View
15 activerecord/test/base_test.rb
@@ -133,8 +133,19 @@ def test_create
topic = Topic.new
topic.title = "New Topic"
topic.save
- topicReloaded = Topic.find(topic.id)
- assert_equal("New Topic", topicReloaded.title)
+ topic_reloaded = Topic.find(topic.id)
+ assert_equal("New Topic", topic_reloaded.title)
+ end
+
+ def test_hashes_not_mangled
+ new_topic = { :title => "New Topic" }
+ new_topic_values = { :title => "AnotherTopic" }
+
+ topic = Topic.new(new_topic)
+ assert_equal new_topic[:title], topic.title
+
+ topic.attributes= new_topic_values
+ assert_equal new_topic_value[:title], topic.title
end
def test_create_many
Please sign in to comment.
Something went wrong with that request. Please try again.