Permalink
Browse files

reducing function calls in the session store

  • Loading branch information...
tenderlove committed Jul 21, 2010
1 parent 4e6cf42 commit f5de56f53768bf07a337c9bf32b397a9d3e61cf0
Showing with 5 additions and 5 deletions.
  1. +5 −5 activerecord/lib/active_record/session_store.rb
@@ -138,17 +138,17 @@ def loaded?
private
def marshal_data!
- return false if !loaded?
- write_attribute(@@data_column_name, self.class.marshal(self.data))
+ return false unless loaded?
+ write_attribute(@@data_column_name, self.class.marshal(data))
end
# Ensures that the data about to be stored in the database is not
# larger than the data storage column. Raises
# ActionController::SessionOverflowError.
def raise_on_session_data_overflow!
- return false if !loaded?
+ return false unless loaded?
limit = self.class.data_column_size_limit
- if loaded? and limit and read_attribute(@@data_column_name).size > limit
+ if limit and read_attribute(@@data_column_name).size > limit
raise ActionController::SessionOverflowError
end
end
@@ -265,7 +265,7 @@ def loaded?
end
def save
- return false if !loaded?
+ return false unless loaded?
marshaled_data = self.class.marshal(data)
if @new_record

0 comments on commit f5de56f

Please sign in to comment.