Permalink
Browse files

copy-edits 819762c

* simplifies some sentences
* use a more neutral language with less you/yours
  • Loading branch information...
1 parent 5f99a89 commit f6a5449d431e5d9096edbf4cb52eb2d82f467925 @fxn fxn committed Mar 5, 2011
Showing with 3 additions and 4 deletions.
  1. +3 −4 railties/guides/source/contributing_to_ruby_on_rails.textile
@@ -349,22 +349,21 @@ $ git commit -a
$ git format-patch master --stdout > my_new_patch.diff
</shell>
-Sanity check the results of this operation: open the diff file in your text editor of choice and make sure that no unintended changes crept in.
+Open the diff file in your text editor of choice to sanity check the results, and make sure that no unintended changes crept in.
-You can check your patches by applying your patch to an different dedicated branch:
+You can also perform an extra check by applying the patch to a different dedicated branch:
<shell>
$ git checkout -b testing_branch
$ git apply --check my_new_patch.diff
</shell>
-You can make sure your patches don't add any whitespace by applying it yourself using the --whitespace=error-all option. Make sure you are on your dedicated test branche and:
+Please make sure the patch does not introduce whitespace errors:
<shell>
$ git apply --whitespace=error-all mynew_patch.diff
</shell>
-
h4. Create a Lighthouse Ticket
Now create a ticket with your patch. Go to the "new ticket":http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/new page at Lighthouse. Fill in a reasonable title and description, remember to attach your patch file, and tag the ticket with the ‘patch’ tag and whatever other subject area tags make sense.

0 comments on commit f6a5449

Please sign in to comment.