Permalink
Browse files

Added protection against proxy setups treating requests as local even…

… when they're not #3898 [stephen_purcell@yahoo.com]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 3a7be80 commit f7359342afbe3e654dfb0e78770493deba7342c9 @dhh dhh committed Mar 16, 2006
Showing with 3 additions and 1 deletion.
  1. +2 −0 actionpack/CHANGELOG
  2. +1 −1 actionpack/lib/action_controller/rescue.rb
View
@@ -1,5 +1,7 @@
*SVN*
+* Added protection against proxy setups treating requests as local even when they're not #3898 [stephen_purcell@yahoo.com]
+
* Added TestRequest#raw_post that simulate raw_post from CgiRequest #3042 [francois.beausoleil@gmail.com]
* Underscore dasherized keys in formatted requests [Jamis Buck]
@@ -60,7 +60,7 @@ def rescue_action_in_public(exception) #:doc:
# the remote IP being 127.0.0.1. For example, this could include the IP of the developer machine when debugging
# remotely.
def local_request? #:doc:
- @request.remote_addr == "127.0.0.1"
+ [@request.remote_addr, @request.remote_ip] == ["127.0.0.1"] * 2
end
# Renders a detailed diagnostics screen on action exceptions.

0 comments on commit f735934

Please sign in to comment.