Permalink
Browse files

copy-edits a couple of exception messages

"Safe Buffer" should either be the constant with the class name,
or go in lower case. I've chosen to follow the same terminology
that is used in the AS core extensiong guide, "safe string",
though "safe buffer" is also used elsewhere, we should pick one.
  • Loading branch information...
1 parent 06b218d commit f7627de206f534cfddfecbb5db7ac894c724e5a8 @fxn fxn committed Sep 8, 2011
Showing with 4 additions and 4 deletions.
  1. +4 −4 activesupport/lib/active_support/core_ext/string/output_safety.rb
@@ -158,17 +158,17 @@ def #{unsafe_method}!(*args) # def capitalize!(*args)
UNAVAILABLE_STRING_METHODS.each do |unavailable_method|
class_eval <<-EOT, __FILE__, __LINE__
# def gsub(*args)
- # raise NoMethodError, "gsub cannot be used with a Safe Buffer object. You should use object.to_str.gsub"
+ # raise NoMethodError, "gsub cannot be used with a safe string. You should use object.to_str.gsub."
# end
def #{unavailable_method}(*args)
- raise NoMethodError, "#{unavailable_method} cannot be used with a Safe Buffer object. You should use object.to_str.#{unavailable_method}"
+ raise NoMethodError, "#{unavailable_method} cannot be used with a safe string. You should use object.to_str.#{unavailable_method}."
end
# def gsub!(*args)
- # raise NoMethodError, "gsub! cannot be used with a Safe Buffer object. You should use object.to_str.gsub!"
+ # raise NoMethodError, "gsub! cannot be used with a safe string. You should use object.to_str.gsub!."
# end
def #{unavailable_method}!(*args)
- raise NoMethodError, "#{unavailable_method}! cannot be used with a Safe Buffer object. You should use object.to_str.#{unavailable_method}!"
+ raise NoMethodError, "#{unavailable_method}! cannot be used with a safe string. You should use object.to_str.#{unavailable_method}!."
end
EOT
end

2 comments on commit f7627de

Owner

fxn replied Sep 8, 2011

Oh, I did but forgot to amend. Thanks!

Please sign in to comment.