Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Use explicit delegation instead of method aliasing for AR::Base.to_pa…

…ram -> AR::Base.id. (closes #5299)

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit f97978ad9137b7a9213fa9d4a58071ac6d23bc7e 1 parent 149f5ca
@jamis jamis authored
View
2  activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Use explicit delegation instead of method aliasing for AR::Base.to_param -> AR::Base.id. #5299 (skaes@web.de)
+
* Refactored ActiveRecord::Base.to_xml to become a delegate for XmlSerializer, which restores sanity to the mega method. This refactoring also reinstates the opinions that type="string" is redundant and ugly and nil-differentiation is not a concern of serialization [DHH]
* Added simple hash conditions to find that'll just convert hash to an AND-based condition string #5143 [hcatlin@gmail.com]. Example:
View
5 activerecord/lib/active_record/base.rb
@@ -1409,7 +1409,10 @@ def id
end
# Enables Active Record objects to be used as URL parameters in Action Pack automatically.
- alias_method :to_param, :id
+ def to_param
+ # can't use alias_method here, because method 'id' optimizes itself on the fly
+ id
+ end
def id_before_type_cast #:nodoc:
read_attribute_before_type_cast(self.class.primary_key)
Please sign in to comment.
Something went wrong with that request. Please try again.