Permalink
Browse files

AssociationCollection#create_by_*, find_or_create_by_* work properly …

…now. [#1108 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  • Loading branch information...
tenderlove authored and jeremy committed Jun 29, 2010
1 parent 78e4d88 commit fad166c15277c72b370c90e890d509d0f6c9af63
@@ -368,6 +368,17 @@ def load_target
end
def method_missing(method, *args)
case method.to_s
when 'find_or_create'
return find(:first, :conditions => args.first) || create(args.first)
when /^find_or_create_by_(.*)$/
rest = $1
return send("find_by_#{rest}", *args) ||
method_missing("create_by_#{rest}", *args)
when /^create_by_(.*)$/
return create Hash[$1.split('_and_').zip(args)]
end
if @target.respond_to?(method) || (!@reflection.klass.respond_to?(method) && Class.respond_to?(method))
if block_given?
super { |*block_args| yield(*block_args) }
@@ -21,6 +21,68 @@ def setup
Client.destroyed_client_ids.clear
end
def test_create_by
person = Person.create! :first_name => 'tenderlove'
post = Post.find :first
assert_equal [], person.readers
assert_nil person.readers.find_by_post_id post.id
reader = person.readers.create_by_post_id post.id
assert_equal 1, person.readers.count
assert_equal 1, person.readers.length
assert_equal post, person.readers.first.post
assert_equal person, person.readers.first.person
end
def test_create_by_multi
person = Person.create! :first_name => 'tenderlove'
post = Post.find :first
assert_equal [], person.readers
reader = person.readers.create_by_post_id_and_skimmer post.id, false
assert_equal 1, person.readers.count
assert_equal 1, person.readers.length
assert_equal post, person.readers.first.post
assert_equal person, person.readers.first.person
end
def test_find_or_create_by
person = Person.create! :first_name => 'tenderlove'
post = Post.find :first
assert_equal [], person.readers
assert_nil person.readers.find_by_post_id post.id
reader = person.readers.find_or_create_by_post_id post.id
assert_equal 1, person.readers.count
assert_equal 1, person.readers.length
assert_equal post, person.readers.first.post
assert_equal person, person.readers.first.person
end
def test_find_or_create
person = Person.create! :first_name => 'tenderlove'
post = Post.find :first
assert_equal [], person.readers
assert_nil person.readers.find(:first, :conditions => {
:post_id => post.id
})
reader = person.readers.find_or_create :post_id => post.id
assert_equal 1, person.readers.count
assert_equal 1, person.readers.length
assert_equal post, person.readers.first.post
assert_equal person, person.readers.first.person
end
def force_signal37_to_load_all_clients_of_firm
companies(:first_firm).clients_of_firm.each {|f| }
end
@@ -400,6 +400,7 @@ def create_table(*args, &block)
create_table :readers, :force => true do |t|
t.integer :post_id, :null => false
t.integer :person_id, :null => false
t.boolean :skimmer, :default => false
end
create_table :shape_expressions, :force => true do |t|

0 comments on commit fad166c

Please sign in to comment.