Permalink
Browse files

Removed dumping of template assigns on the rescue page as it would ve…

…ry easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 8694a79 commit fe00c275cd1c379af5e4e2a72040febea6b98632 @dhh dhh committed Apr 30, 2005
@@ -1,5 +1,7 @@
*SVN*
+* Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222
+
* Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log. Example:
<% benchmark "Notes section" do %>
@@ -33,10 +33,6 @@
request_dump = request_parameters_without_action.inspect.gsub(/,/, ",\n")
session_dump = @request.session.instance_variable_get("@data").inspect.gsub(/,/, ",\n")
response_dump = @response.inspect.gsub(/,/, ",\n")
-
- template_assigns = @response.template.instance_variable_get("@assigns")
- %w( response exception template session request template_root template_class url ignore_missing_templates logger cookies headers params ).each { |t| template_assigns.delete(t) }
- template_dump = template_assigns.inspect.gsub(/,/, ",\n")
%>
<h2 style="margin-top: 30px">Request</h2>
@@ -48,6 +44,3 @@
<h2 style="margin-top: 30px">Response</h2>
<b>Headers</b>: <%=h @response.headers.inspect.gsub(/,/, ",\n") %><br/>
-
-<p><a href="#" onclick="document.getElementById('template_dump').style.display='block'; return false;">Show template parameters</a></p>
-<div id="template_dump" style="display:none"><%= debug(template_assigns) %></div>

0 comments on commit fe00c27

Please sign in to comment.