Skip to content
Browse files

Should be checking if file exists or not.

I found this bug when running rake test:uncommitted 
on a newly generated rails app which don't have
test file for application_controller.
Can see detail here #3461
  • Loading branch information...
1 parent 588faed commit fe67501e62429a8d9c666837740cf9c1de1d4f87 @arunagw arunagw committed Nov 8, 2011
Showing with 9 additions and 3 deletions.
  1. +9 −3 railties/lib/rails/test_unit/testing.rake
View
12 railties/lib/rails/test_unit/testing.rake
@@ -121,10 +121,16 @@ namespace :test do
models = changed_since_checkin.select { |path| path =~ /app[\\\/]models[\\\/].*\.rb$/ }
controllers = changed_since_checkin.select { |path| path =~ /app[\\\/]controllers[\\\/].*\.rb$/ }
- unit_tests = models.map { |model| "test/unit/#{File.basename(model, '.rb')}_test.rb" }
- functional_tests = controllers.map { |controller| "test/functional/#{File.basename(controller, '.rb')}_test.rb" }
+ unit_tests = models.map do |model|
+ file = "test/unit/#{File.basename(model, '.rb')}_test.rb"
+ file if File.exist?(file)
+ end
+ functional_tests = controllers.map do |controller|
+ file = "test/functional/#{File.basename(controller, '.rb')}_test.rb"
+ file if File.exist?(file)
+ end
- unit_tests.uniq + functional_tests.uniq
+ (unit_tests.uniq + functional_tests.uniq).compact
end
t.libs << 'test'

1 comment on commit fe67501

@sobrinho

Could reduce duplication :)

(unit_test + functional_tests).uniq.select do |file|
  File.exist?(file)
end
Please sign in to comment.
Something went wrong with that request. Please try again.