From ffff70353dc21c756f5d4be46424d58da5ceaa3e Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Sun, 17 Jan 2021 22:43:05 +0900 Subject: [PATCH] Merge pull request #41147 from OuYangJinTing/fix_query_cache_is_dirty_after_perform_created Fix ActiveRecord::ConnectionAdapters::QueryCache#dirties_query_cache --- .../connection_adapters/abstract/query_cache.rb | 2 +- activerecord/test/cases/adapter_test.rb | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb b/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb index b91cfe410a404..6223e37698494 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb @@ -7,7 +7,7 @@ module ConnectionAdapters # :nodoc: module QueryCache class << self def included(base) #:nodoc: - dirties_query_cache base, :insert, :update, :delete, :truncate, :truncate_tables, + dirties_query_cache base, :create, :insert, :update, :delete, :truncate, :truncate_tables, :rollback_to_savepoint, :rollback_db_transaction, :exec_insert_all base.set_callback :checkout, :after, :configure_query_cache! diff --git a/activerecord/test/cases/adapter_test.rb b/activerecord/test/cases/adapter_test.rb index d4cfaf0bbadac..45fc947f7fa31 100644 --- a/activerecord/test/cases/adapter_test.rb +++ b/activerecord/test/cases/adapter_test.rb @@ -442,6 +442,19 @@ def setup end end + def test_create_with_query_cache + @connection.enable_query_cache! + + count = Post.count + + @connection.create("INSERT INTO posts(title, body) VALUES ('', '')") + + assert_equal count + 1, Post.count + ensure + reset_fixtures("posts") + @connection.disable_query_cache! + end + def test_truncate assert_operator Post.count, :>, 0