Skip to content
This repository
branch: master

Apr 20, 2014

  1. Richard Schneeman

    Merge pull request #14820 from akshay-vishnoi/doc_changes

    [ci skip] builtin -> built-in
    authored April 20, 2014
  2. Arthur Nogueira Neves

    Merge pull request #14821 from jonatack/patch-5

    Fix code indentation and improve formatting
    authored April 20, 2014
  3. Akshay Vishnoi

    [ci skip] builtin -> built-in

  4. Jon Atack

    Fix code indentation and improve formatting

    in the Getting Started Guide.
    
    This PR regroups #14817, #14818 and #14819 into one commit.
    
    [skip ci]
    authored April 20, 2014
  5. Robin Dupret

    Merge pull request #14816 from jonatack/patch-2

    Grammar fix in Getting Started Guide [ci skip]
    authored April 20, 2014
  6. Jon Atack

    Grammar fix in Getting Started Guide

    authored April 20, 2014
  7. Andrew White

    Make URL escaping more consistent

    1. Escape '%' characters in URLs - only unescaped data
       should be passed to URL helpers
    
    2. Add an `escape_segment` helper to `Router::Utils`
       that escapes '/' characters
    
    3. Use `escape_segment` rather than `escape_fragment`
       in optimized URL generation
    
    4. Use `escape_segment` rather than `escape_path`
       in URL generation
    
    For point 4 there are two exceptions. Firstly, when a route uses wildcard
    segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
    characters. This means that wildcard routes can't be optimized. Secondly,
    if a `:controller` segment is used in the path then this uses `escape_path`
    as the controller may be namespaced.
    
    Fixes #14629, #14636 and #14070.
    authored April 20, 2014
  8. Andrew White

    Optimize URI escaping

    The URI::Parser#escape method is a general use method that has to deal
    with a variety of input however our use of it is limited in scope so
    we can increase the performance by implementing our specific needs
    within ActionDispatch::Journey::Router::Utils directly.
    
    If there is no encoding required then there is no change in performance
    or number of objects allocated, but for each character that needs to be
    encoded we save five object allocations and gain a performance boost.
    The performance boost seen varies from 20% when there is one character
    to over 50% when encoding ten characters.
    authored April 19, 2014
  9. Edho Arief

    Always escape string passed to url helper.

    Makes it clear that anything passed with the helper must not be percent encoded.
    
    Fixes previous behavior which tricks people into believing passing
    non-percent-encoded will generate a proper percent-encoded path while in
    reality it doesn't ('%' isn't escaped).
    
    The intention is nice but the heuristic is broken.
    authored April 07, 2014 pixeltrix committed April 20, 2014

Apr 19, 2014

  1. Guillermo Iguaran

    Merge pull request #14811 from qrush/master

    Remove statement assuming coffee shop/public space wifi is inherently insecure
    authored April 19, 2014
  2. Nick Quaranto

    Remove statement assuming coffee shop/public space wifi is inherently…

    … insecure
    authored April 19, 2014
  3. Godfrey Chan

    Merge pull request #14810 from robin850/patch-18

    Don't rely on Arel master in bug report template
    authored April 19, 2014
  4. Robin Dupret

    Don't rely on Arel master in bug report template [ci skip]

    We should rely instead on the version supported by Active Record
    
    Closes #14809
    authored April 19, 2014
  5. Andrew White

    Merge pull request #14805 from akshay-vishnoi/structure-change

    multibyte_conformance.rb --> multibyte_conformance_test.rb
    authored April 19, 2014
  6. Arthur Nogueira Neves

    Merge pull request #14804 from akshay-vishnoi/doc_changes

    "subhash" --> "sub-hash"
    authored April 19, 2014
  7. Xavier Noria

    Merge pull request #14808 from akalyaev/few-corrections-in-rails-init…

    …ialization-guides
    
    Few corrections in Rails Initialization Guides
    authored April 19, 2014
  8. Anton Kalyaev

    wrap methods in backticks [ci skip]

    authored April 19, 2014

Apr 18, 2014

  1. Akshay Vishnoi

    "subhash" --> "sub-hash"

  2. Akshay Vishnoi

    multibyte_conformance.rb --> multibyte_conformance_test.rb

  3. Rafael Mendonça França

    Merge pull request #14799 from ernie/string-first-last-fix

    Fix inconsistent behavior from String#first/#last
    authored April 18, 2014
  4. Ernie Miller

    Fix inconsistent behavior from String#first/#last

    While calling String#first or String#last with zero or a Fixnum < the
    string's length returns a new string, a Fixnum >= the string's length
    returns the string itself. This inconsistency can lead to inadvertent
    mutation of a string.
    authored April 18, 2014
  5. Yves Senn

    Merge pull request #14796 from kuldeepaggarwal/fix-save-issue

    when a destroyed record is duped, it is no longer ´destroyed?`.
    authored April 18, 2014
  6. Kuldeep Aggarwal

    `@destroyed` should always be set to `false` when an object is duped.

  7. Yves Senn

    Merge pull request #14798 from kuldeepaggarwal/fix-warning

    remove warning while running TEST CASES
    authored April 18, 2014
  8. Kuldeep Aggarwal

    remove warning

    `warning: ambiguous first argument; put parentheses or even spaces`
  9. Vijay Dev

    Merge branch 'master' of github.com:rails/docrails

    authored April 18, 2014
  10. Rafael Mendonça França

    Merge pull request #14795 from braddunbar/uglifier

    :uglify -> :uglifier
    authored April 18, 2014
  11. brad dunbar

    :uglify -> :uglifier

    The name of the gem is `uglifier` and all other references
    use `uglifier`, not `uglify`.
    authored April 18, 2014
  12. Rafael Mendonça França

    Merge pull request #14790 from krisselden/optimize-postgres-selects

    Optimize select_value, select_values, select_rows in Postgresql adapter.
    authored April 18, 2014
  13. Rafael Mendonça França

    Merge pull request #14793 from arthurnn/fixes_8928

    Fixed has_many association to make it support irregular inflections.
    authored April 18, 2014
  14. Arthur Nogueira Neves

    Regression test for irregular inflection on has_many

    Also add a Changelog entry
    
    [related #9702]
    [fixes #8928]
    authored April 18, 2014
  15. Javier Goizueta

    Singularize association names before camelization

    So that irregular multi-word pluralization rules have to be defined only for snake-case strings.
    authored March 13, 2013 arthurnn committed April 18, 2014
  16. Steven Harman

    Fix spelling and proper nouns

    [ci skip]
    authored April 17, 2014

Apr 17, 2014

  1. Rafael Mendonça França

    Merge pull request #14786 from PaulL1/patch-1

    CSRF protection should rescue exception not extend
    authored April 17, 2014
  2. Kris Selden

    Optimize select_value, select_values, select_rows and dry up checking…

    … whether to exec with cache for Postgresql adapter
    
    Reduces creating unused objects, with the most dramatic reduction in select_values which used to map(&:first) an array of single element arrays.
    authored April 17, 2014
Something went wrong with that request. Please try again.