Permalink
Commits on Feb 20, 2017
  1. Merge pull request #27925 from robin850/hwia-removal

    Remove the top-level `HashWithIndifferentAccess` contant
    kaspth committed on GitHub Feb 20, 2017
  2. Merge pull request #28059 from y-yagi/do_not_run_git_init_inside_test…

    …_dummy
    
    Do not run `git init` in dummy application
    guilleiguaran committed on GitHub Feb 20, 2017
  3. Merge pull request #28070 from kamipo/improve_create_table_force_true

    Improve `create_table force: true`
    guilleiguaran committed on GitHub Feb 20, 2017
  4. Merge pull request #28073 from bogdanvlviv/routes-in-tests

    Add assertion to polymorphic_routes_test.rb
    guilleiguaran committed on GitHub Feb 20, 2017
Commits on Feb 19, 2017
  1. Set correct "routes" in tests cases

    bogdanvlviv committed Feb 19, 2017
  2. Add assertion to polymorphic_routes_test.rb

    The assertion will ensure that the behavior doesn't regress.
      assert_equal "/projects", polymorphic_path("projects")
    
    Remove FIXME related to polymorphic_url behavior.
    polymorphic_url with Symbol or String works equally.
    Example:
    
      default_url_options[:host] = "example.com"
    
      polymorphic_url(:projects)  # => "http://example.com/projects"
      polymorphic_url("projects") # => "http://example.com/projects"
    
    Related to 37d4415
    bogdanvlviv committed Feb 19, 2017
  3. Deprecate the top-level `HashWithIndifferentAccess` contant

    This constant was kept for the sake of backward compatibility; it
    is still available under `ActiveSupport::HashWithIndifferentAccess`.
    
    Furthermore, since Ruby 2.5 (https://bugs.ruby-lang.org/issues/11547)
    won't support top level constant lookup, people would have to update
    their code anyway.
    robin850 committed Feb 6, 2017
  4. Merge pull request #28013 from iguchi1124/fix-missing-namespace-wrapper

    Add missing module namespacing wrapper
    chancancode committed on GitHub Feb 19, 2017
  5. Merge pull request #28069 from st0012/change-back-frozen-string

    Unfreeze interpolated string because it's unnecessary.
    matthewd committed on GitHub Feb 19, 2017
  6. Unfreeze interpolated string because it's useless.

    st0012 committed Feb 19, 2017
  7. Improve `create_table force: true`

    Extra `data_source_exists?(table_name)` is unneeded if
    `drop_table(table_name, if_exists: true)` directly.
    kamipo committed Feb 19, 2017
Commits on Feb 18, 2017
  1. Do not run `git init` in dummy application

    y-yagi committed Feb 18, 2017
  2. Merge pull request #28058 from y-yagi/follow_up_to_27608

    Remove deprecate passing string to `:if` and `:unless` conditional options [ci skip]
    maclover7 committed on GitHub Feb 18, 2017
  3. Remove deprecate passing string to `:if` and `:unless` conditional op…

    …tions [ci skip]
    
    Follow up to #27608
    y-yagi committed Feb 18, 2017
Commits on Feb 17, 2017
  1. Merge pull request #28049 from notapatch/master

    Change engines guide to demonstrate maintained forum
    maclover7 committed on GitHub Feb 17, 2017
  2. Merge pull request #28053 from kamipo/remove_doc

    Remove `:doc:` for `NumericalityValidator` [ci skip]
    amatsuda committed on GitHub Feb 17, 2017
  3. Change engines guide to demonstrate maintained forum

    Change Rails engine guide to references a maintained project
    Thredded instead of the abandoned project Forem. I chose
    Thredded as Forem's closing note (below) suggests the choice.
    https://github.com/rubysherpas/forem/blob/rails4/README.md
    notapatch committed Feb 17, 2017
  4. Remove `:doc:` for `NumericalityValidator` [ci skip]

    The `:doc:` was added in cdb9d7f but `NumericalityValidator` is already
    `:nodoc:` class. `:doc:` is unneeded.
    
    https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validations/numericality.rb#L3
    kamipo committed Feb 17, 2017
  5. Merge pull request #28047 from Erol/fix-i18n-documentation-typo

    Fix typo in I18n Guide [ci skip]
    senny committed on GitHub Feb 17, 2017
  6. Fix typo in I18n Guide [ci skip]

    Erol committed Feb 17, 2017
  7. Merge pull request #28040 from kenta-s/fix-doc-in-multibyte-chars

    Fix doc in Multibyte::Chars [ci skip]
    maclover7 committed on GitHub Feb 17, 2017
Commits on Feb 16, 2017
  1. Add test for generate namespaced integration test

    iguchi1124 committed Feb 16, 2017
Commits on Feb 15, 2017
  1. Merge pull request #28026 from Sen-Zhang/fix_some_typos_in_comments

    Change ActiveModel::Validation to ActiveModel::Validations in comments
    maclover7 committed on GitHub Feb 15, 2017
  2. change ActiveModel::Validation to ActiveModel::Validations in comments

    Sen-Zhang committed Feb 15, 2017
  3. Merge pull request #28016 from kenta-s/fix-docs-of-deprecated_method_…

    …warning
    
    Remove redundant namespaces from sample code of `deprecated_method_wa…
    maclover7 committed on GitHub Feb 15, 2017
  4. Merge pull request #27993 from koic/fix_test_ar_value_too_long_using_…

    …oracle
    
    Fix a tests of AR::ValueTooLong when using OracleAdapter
    eileencodes committed on GitHub Feb 15, 2017
  5. Merge pull request #28018 from frewsxcv/patch-1

    Indicate units of 'limit' in 'Integer' error message.
    eileencodes committed on GitHub Feb 15, 2017
  6. Indicate units of 'limit' in 'Integer' error message.

    frewsxcv committed on GitHub Feb 15, 2017
  7. Add missing module namespacing wrapper

    refs: #28011
    iguchi1124 committed Feb 15, 2017
  8. Merge pull request #27605 from mtsmfm/fix-generator-command-for-neste…

    …d-rails-engine-take-2
    
    Fix generator command for nested (namespaced) rails engine (take 2)
    chancancode committed on GitHub Feb 15, 2017
Commits on Feb 14, 2017
  1. Merge pull request #28000 from kamipo/remove_unused_ddl_helper

    Remove unused DdlHelper in ForeignKeyTest
    rafaelfranca committed on GitHub Feb 14, 2017