Skip to content
Commits on May 26, 2016
  1. @fxn
Commits on May 25, 2016
  1. @jeremy

    Merge pull request #25139 from vipulnsward/revert-bundler-version

    Revert back to a compatible bundler version
    jeremy committed May 25, 2016
  2. @rafaelfranca

    Merge pull request #25138 from ysksn/test_delegation

    Add tests for keyword arg to: for Module#delegate
    rafaelfranca committed May 25, 2016
  3. @vipulnsward
  4. @maclover7 @jeremy

    CI: run Action Cable browser tests in Sauce Labs

    Allow failures until test runs are consistently stable, not hanging.
    
    Closes #24943.
    
    Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
    maclover7 committed with jeremy May 9, 2016
  5. @ysksn
Commits on May 24, 2016
  1. @maclover7

    Merge pull request #25134 from malept/consistent-hash-examples

    Normalize whitespace for Hash#compact documentation
    maclover7 committed May 24, 2016
  2. @malept

    Normalize whitespace for Hash#compact documentation [ci skip]

    This is a similar change that occurred for Hash#except in #21087.
    malept committed May 24, 2016
  3. @rafaelfranca

    Don't delegate to private methods of the targer

    And make sure that it doesn't even try to call the method in the target.
    rafaelfranca committed May 24, 2016
  4. @rafaelfranca

    Merge pull request #25119 from javan/actioncable/blade-build

    Build action_cable.js with Blade
    rafaelfranca committed May 24, 2016
  5. @rafaelfranca

    Merge pull request #23930 from gsamokovarov/module-delegate-missing-to

    Introduce Module#delegate_missing_to
    rafaelfranca committed May 24, 2016
  6. @rafaelfranca

    Merge pull request #25131 from javierhonduco/javierhonduco/clone_dept…

    …h_to_1
    
    Cloning depth set to 1
    rafaelfranca committed May 24, 2016
  7. @javierhonduco

    Cloning depth set to 1

    javierhonduco committed May 24, 2016
  8. @rafaelfranca

    Merge pull request #25130 from xhpwn/master

    Improved commands in README with markdown formatting
    rafaelfranca committed May 24, 2016
  9. @xhpwn

    Minor comment language correction.

    xhpwn committed May 24, 2016
  10. @javan

    Remove package:clean task

    Introduced in d6f2000 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
    javan committed May 23, 2016
  11. @javan

    Build action_cable.js with Blade

    javan committed May 23, 2016
  12. @xhpwn

    Fixing commands with Markdown formatting

    Adding '$' to emulate shell syntax
    xhpwn committed May 24, 2016
  13. @maclover7 @rafaelfranca
  14. @schneems

    Merge pull request #25061 from eugeneius/rails_max_threads_mysql_sqlite

    Use RAILS_MAX_THREADS as pool size on all adapters
    schneems committed May 24, 2016
  15. @vipulnsward

    Merge pull request #25126 from bquorning/this-is-not-an-alias

    [] and read_attribute are not aliases [ci skip]
    vipulnsward committed May 24, 2016
  16. @bquorning

    [] and read_attribute are not aliases [ci skip]

    The `#[]` method *used to be* an alias of `#read_attribute`, but since Rails 4
    (10f6f90), it will raise an exception for
    missing attributes. Saying that it is an alias is confusing.
    bquorning committed May 24, 2016
  17. @eugeneius

    Use RAILS_MAX_THREADS as pool size on all adapters

    When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
    connection pool size, so that there are always enough connections
    available to serve Action Cable requests.
    
    The same logic applies when using any other adapter.
    eugeneius committed May 18, 2016
Commits on May 23, 2016
  1. @rafaelfranca

    Revert "Add default exceptions affected by suppress (#25099)"

    This reverts commit 2849220.
    
    Reason: `suppress` without an argument doesn't actually tell what is
    supressing. Also, it can be confused with ActiveRecord::Base#suppress.
    rafaelfranca committed May 23, 2016
  2. @ixti @rafaelfranca

    Add default exceptions affected by suppress (#25099)

    * Add default exceptions affected by suppress
    
        suppress { do_something_that_might_fail }
    
        # instead of
    
        begin
          do_something_that_might_fail
        rescue
        end
    
        # or
    
        do_something_that_might_fail rescue nil
    
    * Do not add default exceptions list constant
    
    [Rafael Mendonça França + Alexey Zapparov]
    ixti committed with rafaelfranca May 23, 2016
  3. @maclover7

    Merge pull request #25114 from y-yagi/remove_qualified_const_from_guide

    remove deprecated `Module#qualified_const_` from guide [ci skip]
    maclover7 committed May 23, 2016
  4. @rafaelfranca

    Merge pull request #25110 from andrii/fix_scaffold_css

    Fix and optimize scaffold CSS
    rafaelfranca committed May 23, 2016
  5. @mattcg @jeremy

    Respect `log_warning_on_csrf_failure` setting for all CSRF failures

    CSRF verification for non-XHR GET requests (cross-origin `<script>`
    tags) didn't check this flag before logging failures.
    
    Setting `config.action_controller.log_warning_on_csrf_failure = false`
    now disables logging for these CSRF failures as well.
    
    Closes #25086.
    
    Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
    mattcg committed with jeremy May 20, 2016
  6. @y-yagi
Commits on May 22, 2016
  1. @andrii
Commits on May 21, 2016
  1. @vipulnsward @jeremy

    Remove Blade gem dependency

    Apps that depend on Action Cable don't need Blade for app development,
    so we can remove the gem dependency.
    
    We do need Blade for Action Cable dev, so we bundle it in the Gemfile.
    
    Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
    vipulnsward committed with jeremy May 22, 2016
  2. @sgrif

    Merge pull request #25076 from jeroenvisser101/keep-to-max-length

    Change comments to not exceed 80 characters
    sgrif committed May 21, 2016
  3. @kaspth

    Merge pull request #25101 from maclover7/jm-rm-space-1

    Remove space, properly italicize
    kaspth committed May 21, 2016
  4. @kaspth

    Merge pull request #25100 from maclover7/jm-add-backticks

    Add backticks to `config/secrets.yml`
    kaspth committed May 21, 2016
  5. @maclover7
Something went wrong with that request. Please try again.