Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jan 26, 2009
  1. @dubek @NZKoz

    Mysql#reconnect is set according to the 'reconnect' key in the connec…

    dubek authored NZKoz committed
    …tion spec.
    The 'reconenct' boolean option is read from the connection specification
    and is used to set the reconnect attribute of Mysql.  The default is
    false in order not to change existing application behaviour.
    Also, reconnect is set AFTER real_connect is called, so its value sticks
    (the mysql gem sets reconnect to false inside real_connect).
    Signed-off-by: Michael Koziarski <>
    [#1797 state:committed]
Commits on Nov 19, 2008
  1. @lifo
Commits on Nov 8, 2008
  1. @jeremy
Commits on Nov 7, 2008
  1. @lifo
  2. @nicksieger @lifo

    Simplify dispatcher callbacks to eliminate unnecessary stale thread p…

    nicksieger authored lifo committed
    …urging. [Nick Sieger, Pratik Naik]
    Signed-off-by: Pratik Naik <>
  3. @NZKoz

    Revert commit which breaks all the tests.

    NZKoz authored
    This reverts commit 8adb79b.
Commits on Nov 6, 2008
  1. @dhh

    Stop logging SHOW FIELDS and SET SQL_AUTO_IS_NULL=0 for the MysqlAdap…

    dhh authored
    …ter as they only clutter up the log and offer no value [DHH]
Commits on Nov 5, 2008
  1. @lifo
  2. @Narnach @lifo

    Ensure ActiveRecord::ConnectionPool.connected? handles undefined conn…

    Narnach authored lifo committed
    …ections. [#936 state:resolved]
    Signed-off-by: Pratik Naik <>
Commits on Oct 30, 2008
  1. @josh

    It is not necessary to store QueryCache in a thread local since the c…

    josh authored
    …ache is local to the connection object which is managed by the connection pool
  2. @josh
Commits on Oct 26, 2008
  1. @NZKoz
Commits on Oct 25, 2008
  1. @AdamMajer @NZKoz

    Fix binary data corruption bug in PostgreSQL adaptor

    AdamMajer authored NZKoz committed
      1. Move the binary escape/unescape from column to the driver - we should store binary data AR just like most other adaptors
      2. check to make sure we only unescape bytea data
         PGresult.ftype( column ) == 17
      that is passed to us in escaped format
         PGresult.fformat( column ) == 0
    Signed-off-by: Michael Koziarski <>
    [#1063 state:committed]
Commits on Oct 9, 2008
  1. @FooBarWidget @NZKoz

    Add documentation for AbstractAdapter#sanitize_limit, and make its co…

    FooBarWidget authored NZKoz committed
    …de more readable.
    Signed-off-by: Michael Koziarski <>
    [#1068 status:committed]
Commits on Oct 5, 2008
  1. @lifo

    Merge docrails

    lifo authored
Commits on Oct 4, 2008
  1. @alk @NZKoz

    made ConnectionPool#checkout more robust by trying to loot dead threa…

    alk authored NZKoz committed
    …ds when pool is empty
    Signed-off-by: Michael Koziarski <>
    [#1169 state:committed]
  2. @alk @NZKoz

    Fix race in ConnectionPool#checkout

    alk authored NZKoz committed
    After releasing monitor some connection(s) may appear in pool before monitor is re-aquired.
    When this happens we'll wait for connection which is already available.
    Signed-off-by: Michael Koziarski <>
  3. @alk @NZKoz

    don't quote decimal values for mysql. It doesn't make sense and break…

    alk authored NZKoz committed
    …s in newer versions of mysql
    Signed-off-by: Michael Koziarski <>
    [#1168 state:committed]
Commits on Oct 3, 2008
  1. @NZKoz

    Make sure recreate MySQL test database with the proper encoding and c…

    Luca Guidi authored NZKoz committed
    …ollation [#1165 state:resolved]
    Signed-off-by: Michael Koziarski <>
    [#1165 state:committed]
Commits on Sep 15, 2008
  1. @fcheung @jeremy

    Deal with MySQL's quirky handling of defaults and blob/text columns

    fcheung authored jeremy committed
    [#1043 state:committed]
    Signed-off-by: Jeremy Kemper <>
Commits on Sep 13, 2008
  1. @lifo

    Merge docrails

    lifo authored
Commits on Sep 10, 2008
  1. @tarmo @NZKoz

    Support :limit on update_all so that has_many with :limit can be safe…

    tarmo authored NZKoz committed
    …ly updated
    Signed-off-by: Michael Koziarski <>
Commits on Sep 5, 2008
  1. @dhh
  2. @dhh
Commits on Sep 4, 2008
  1. @NZKoz
  2. @nicksieger @jeremy

    Remove flawed execute("ROLLBACK") approach; #reset! defaults to nothing

    nicksieger authored jeremy committed
    Will need community help to fill out what #reset! should do for each adapter
    Signed-off-by: Jeremy Kemper <>
  3. @nicksieger @jeremy

    Default connection allow_concurrency to false (for PostgreSQL)

    nicksieger authored jeremy committed
    Signed-off-by: Jeremy Kemper <>
  4. @nicksieger @NZKoz

    Deprecate verification_timeout and verify before reset

    nicksieger authored NZKoz committed
    Signed-off-by: Michael Koziarski <>
  5. @jeremy
  6. @jeremy
Commits on Aug 29, 2008
  1. @nicksieger
  2. @nicksieger

    Remove some synchronization that's probably overkill, assuming one do…

    nicksieger authored
    …esn't establish connections frequently
  3. @nicksieger

    Collapse connection pool class hierarchy; YAGNI.

    nicksieger authored
    - Add connection checkin and checkout callbacks to adapter to allow
      adapter-specific customization of behavior (e.g., JRuby w/ JNDI)
  4. @nicksieger

    Make clear_active_connections! also return stale connections back to …

    nicksieger authored
    …the pool
    - also clean up some cruft remaining from per-thread connection cache
  5. @nicksieger

    Remove CachedConnectionPerThread per-thread pooling mechanism in favo…

    nicksieger authored
    …r of a fixed pool with default maximum of 5 connections
Something went wrong with that request. Please try again.