Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 29, 2013
  1. @carlosantoniodasilva
Commits on Jan 18, 2013
  1. @fxn

    iterates the RDoc of update_column(s)

    fxn authored
    This revision makes crystal clear that the methods go
    straight to the database and update the receiver. It
    also adds and example, and removes the duplication
    in the singular and plural forms by referring one to
    the other.
Commits on Jan 3, 2013
  1. Change docs to use update instead of update_attributes

    Amparo Luna + Guillermo Iguaran authored
  2. Rename update_attributes method to update, keep update_attributes as …

    Amparo Luna + Guillermo Iguaran authored
    …an alias
Commits on Dec 7, 2012
  1. @carlosantoniodasilva

    Unscope update_column(s) query to ignore default scope

    carlosantoniodasilva authored
    When applying default_scope to a class with a where clause, using
    update_column(s) could generate a query that would not properly update
    the record due to the where clause from the default_scope being applied
    to the update query.
    
        class User < ActiveRecord::Base
          default_scope where(active: true)
        end
    
        user = User.first
        user.active = false
        user.save!
    
        user.update_column(:active, true) # => false
    
    In this situation we want to skip the default_scope clause and just
    update the record based on the primary key. With this change:
    
        user.update_column(:active, true) # => true
    
    Fixes #8436.
Commits on Nov 29, 2012
  1. @jeremy

    Move instantiation responsibilities from Inheritance to Persistence. …

    jeremy authored
    …Have Inheritance#discriminate_class_for_record handle STI lookup duties.
  2. @rafaelfranca

    Remove observers and sweepers

    rafaelfranca authored
    They was extracted from a plugin.
    
    See https://github.com/rails/rails-observers
    
    [Rafael Mendonça França + Steve Klabnik]
Commits on Nov 21, 2012
  1. @rafaelfranca
Commits on Nov 19, 2012
  1. @carlosantoniodasilva
Commits on Nov 17, 2012
  1. @Tho85

    AR::Base.becomes should not change the STI type

    Tho85 authored
    If you want to change the STI type too, use AR::Base.becomes! instead
Commits on Nov 2, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	actionpack/lib/action_controller/metal/mime_responds.rb
    	activerecord/lib/active_record/attribute_methods.rb
    	guides/source/working_with_javascript_in_rails.md
Commits on Oct 28, 2012
  1. @henrik

    Enable update_column(s) for the primary key attribute.

    henrik authored
    Didn't work before because it updated the model-in-memory first, so the DB query couldn't find the record.
Commits on Oct 23, 2012
  1. @AvnerCohen

    Another batch of hash syntax changes to comment, this time around, I …

    AvnerCohen authored
    …tried to keep 'output' messages untouched.
Commits on Oct 10, 2012
  1. @vijaydev

    copy edits [ci skip]

    vijaydev authored
  2. @AHaymond
Commits on Sep 28, 2012
  1. @jonleighton

    Support for partial inserts.

    jonleighton authored
    When inserting new records, only the fields which have been changed
    from the defaults will actually be included in the INSERT statement.
    The other fields will be populated by the database.
    
    This is more efficient, and also means that it will be safe to
    remove database columns without getting subsequent errors in running
    app processes (so long as the code in those processes doesn't
    contain any references to the removed column).
Commits on Sep 19, 2012
  1. @guilleiguaran

    Update AR::Base.create and AR:Base#update_attributes docs to remove r…

    guilleiguaran authored
    …eferences to mass assignment options
Commits on Sep 17, 2012
  1. @guilleiguaran
  2. @guilleiguaran
Commits on Sep 3, 2012
  1. @senny

    set the configured #inheritance_column on #become (#7503)

    senny authored senny committed
    I had to create a new table because I needed an STI table,
    which does not have both a "type" and a "custom_type"
    
    the test fails with:
      1) Error:
    test_alt_becomes_works_with_sti(InheritanceTest):
    NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber">
        /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing'
        /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing'
        /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes'
        test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti'
        test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
Commits on Aug 26, 2012
  1. @rafaelfranca
  2. @rafaelfranca
  3. @rafaelfranca

    Revert "Remove update_attribute."

    rafaelfranca authored
    This reverts commit a7f4b0a.
    
    Conflicts:
    	activerecord/lib/active_record/associations/has_one_association.rb
    	activerecord/lib/active_record/persistence.rb
    	activerecord/test/cases/base_test.rb
    	activerecord/test/cases/dirty_test.rb
    	activerecord/test/cases/timestamp_test.rb
Commits on Aug 19, 2012
  1. @carlosantoniodasilva

    Remove private verify readonly attr method

    carlosantoniodasilva authored
    This method was added to be shared between update_attribute and
    update_column in 50725ce, but since
    update_attribute was removed, and update_column has changed to delegate
    to update_columns, the method is not used anywhere anymore.
    
    Also remove "key.to_s" conversion when raising readonly error, since
    the key is being interpolated.
Commits on Aug 2, 2012
  1. @fxn
Commits on Jul 30, 2012
  1. @rafaelfranca

    Remove the deprecation of update_column.

    rafaelfranca authored
    update_column was suggested as replacement of update_attribute at the
    last release of 3-2-stable, so deprecating it now will confuse the
    users.
Commits on Jul 27, 2012
  1. @rafaelfranca

    Revert "Removing composed_of from ActiveRecord."

    rafaelfranca authored
    This reverts commit 14fc8b3.
    
    Reason: we need to discuss a better path from this removal.
    
    Conflicts:
    	activerecord/lib/active_record/reflection.rb
    	activerecord/test/cases/base_test.rb
    	activerecord/test/models/developer.rb
Commits on Jul 24, 2012
  1. @rafaelfranca
  2. @rafaelfranca
  3. @smartinez87 @rafaelfranca

    New #update_columns method.

    smartinez87 authored rafaelfranca committed
Commits on Jun 18, 2012
  1. @steveklabnik

    Removing composed_of from ActiveRecord.

    steveklabnik authored
    This feature adds a lot of complication to ActiveRecord for dubious
    value. Let's talk about what it does currently:
    
    class Customer < ActiveRecord::Base
      composed_of :balance, :class_name => "Money", :mapping => %w(balance amount)
    end
    
    Instead, you can do something like this:
    
        def balance
          @balance ||= Money.new(value, currency)
        end
    
        def balance=(balance)
          self[:value] = balance.value
          self[:currency] = balance.currency
          @balance = balance
        end
    
    Since that's fairly easy code to write, and doesn't need anything
    extra from the framework, if you use composed_of today, you'll
    have to add accessors/mutators like that.
    
    Closes #1436
    Closes #2084
    Closes #3807
Commits on Jun 14, 2012
  1. @steveklabnik

    Remove update_attribute.

    steveklabnik authored
    Historically, update_attribute and update_attributes are similar, but
    with one big difference: update_attribute does not run validations.
    These two methods are really easy to confuse given their similar
    names. Therefore, update_attribute is being removed in favor of
    update_column.
    
    See the thread on rails-core here:
    https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA
Commits on Jun 6, 2012
  1. @marcandre
Commits on May 17, 2012
  1. @iGEL

    Don't destroy readonly models

    iGEL authored
Commits on Apr 29, 2012
  1. @jeremyf
Something went wrong with that request. Please try again.