Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 13, 2011
  1. @sikachu @dhh

    Remove `#among?` from Active Support

    sikachu authored dhh committed
    After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.
    
    It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
Commits on Apr 10, 2011
  1. @sikachu @dhh

    Using Object#in? and Object#either? in various places

    sikachu authored dhh committed
    There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
Commits on Mar 29, 2011
  1. @sikachu @pixeltrix

    Update the wildcard route to be non-greedy by default, therefore be a…

    sikachu authored pixeltrix committed
    …ble to match the (.:format) segment [#6605 state:resolved]
    
    After some discussion with Andrew White, it seems like this is a better approach for handling a wildcard route. However, user can still bring back the old behavior by supplying `:format => false` to the route.
    
    Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
Commits on Mar 22, 2011
  1. @sikachu @tenderlove

    Do not show optional (.:format) block for wildcard route [#6605 state…

    sikachu authored tenderlove committed
    …:resolved]
    
    This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default
Something went wrong with that request. Please try again.