Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Aug 14, 2012
  1. @steveklabnik
Commits on Aug 13, 2012
  1. @tenderlove

    oops, should be directory

    tenderlove authored
  2. @tenderlove

    speed up cache directory creation

    tenderlove authored
    Let Rake control the cache directories.  If the directory already
    exists, rake will skip creating it (vs the previous task which would
    always try to mkdir_p)
Commits on Aug 11, 2012
  1. @guilleiguaran

    Move AD default_headers configurations to railtie

    guilleiguaran authored
    ActionDispatch railtie is a better place for
    config.action_dispatch.default_headers settings, users can continue
    overriding those settings in their configuration files if needed.
Commits on Aug 10, 2012
  1. @drogus

    Fix handling SCRIPT_NAME from within mounted engine's

    drogus authored
    When you mount your application at a path, for example /myapp, server
    should set SCRIPT_NAME to /myapp. With such information, rails
    application knows that it's mounted at /myapp path and it should generate
    routes relative to that path.
    Before this patch, rails handled SCRIPT_NAME correctly only for regular
    apps, but it failed to do it for mounted engines. The solution was to
    hardcode default_url_options[:script_name], which is not the best answer
    - it will work only when application is mounted at a fixed path.
    This patch fixes the situation by respecting original value of
    SCRIPT_NAME when generating application's routes from engine and the
    other way round - when you generate engine's routes from application.
    This is done by using one of 2 pieces of information in env - current
    SCRIPT_NAME or SCRIPT_NAME for a corresponding router. This is because
    we have 2 cases to handle:
    - generating engine's route from application: in this situation
      SCRIPT_NAME is basically SCRIPT_NAME set by the server and it
      indicates the place where application is mounted, so we can just pass
      it as :original_script_name in url_options. :original_script_name is
      used because if we use :script_name, router will ignore generating
      prefix for engine
    - generating application's route from engine: in this situation we
      already lost information about the SCRIPT_NAME that server used. For
      example if application is mounted at /myapp and engine is mounted at
      /blog, at this point SCRIPT_NAME is equal /myapp/blog. Because of that
      we need to keep reference to /myapp SCRIPT_NAME by binding it to the
      current router. Later on we can extract it and use when generating url
    Please note that starting from now you *should not* use
    default_url_options[:script_name] explicitly if your server already
    passes correct SCRIPT_NAME to rack env.
    (closes #6933)
  2. @jonleighton

    Remove the dependent_restrict_raises option.

    jonleighton authored
    It's not really a good idea to have this as a global config option. We
    should allow people to specify the behaviour per association.
    There will now be two new values:
    * :dependent => :restrict_with_exception implements the current
      behaviour of :restrict. :restrict itself is deprecated in favour of
    * :dependent => :restrict_with_error implements the new behaviour - it
      adds an error to the owner if there are dependent records present
    See #4727 for the original discussion of this.
Commits on Aug 9, 2012
  1. @homakov
Commits on Aug 8, 2012
  1. @dhh
Commits on Aug 7, 2012
  1. @dhh

    Observers are no longer important enough to get this configuration op…

    dhh authored
    …tion called out at the top level
  2. @dhh

    Revert "The application generator generates `public/humans.txt` with …

    dhh authored
    …some basic data". I dont consider this something most people is going to want most of the time. If you want to add it in your own app, knock yourself out. But it doesnt belong in Rails imo
Commits on Aug 5, 2012
  1. @fxn

    removes usage of Object#in? from the code base (the method remains de…

    fxn authored
    …fined by Active Support)
    Selecting which key extensions to include in active_support/rails
    made apparent the systematic usage of Object#in? in the code base.
    After some discussion in
    we decided to remove it and use plain Ruby, which seems enough
    for this particular idiom.
    In this commit the refactor has been made case by case. Sometimes
    include? is the natural alternative, others a simple || is the
    way you actually spell the condition in your head, others a case
    statement seems more appropriate. I have chosen the one I liked
    the most in each case.
Commits on Aug 2, 2012
  1. @rafaelfranca
Commits on Aug 1, 2012
  1. @kennyj
  2. @jmazzi
  3. @pferdefleisch @rafaelfranca

    Updated scaffold_controller generator docs #7146

    pferdefleisch authored rafaelfranca committed
    It was just a copy of the controller generator documentation which was
    misleading.  It doesn't accept arguments for views.  This seems more
    descriptive as well.
    Respect 80 char limit. #7147
    Made a nicer paragraph #7147
Commits on Jul 31, 2012
  1. @davidcelis

    Make ActiveSupport::Inflector locale aware and multilingual

    davidcelis authored
    The Inflector is currently not very supportive of internationalized
    websites. If a user wants to singularize and/or pluralize words based on
    any locale other than English, they must define each case in locale
    files. Rather than create large locale files with mappings between
    singular and plural words, why not allow the Inflector to accept a
    This patch makes ActiveSupport::Inflector locale aware and uses `:en`` unless
    otherwise specified. Users will still be provided a list of English (:en)
    inflections, but they may additionally define inflection rules for other
    locales. Each list is kept separately and permanently. There is no reason to
    limit users to one list of inflections:
        ActiveSupport::Inflector.inflections(:es) do |inflect|
          inflect.plural(/$/, 's')
          inflect.plural(/([^aeéiou])$/i, '\1es')
          inflect.plural(/([aeiou]s)$/i, '\1')
          inflect.plural(/z$/i, 'ces')
          inflect.plural(/á([sn])$/i, 'a\1es')
          inflect.plural(/é([sn])$/i, 'e\1es')
          inflect.plural(/í([sn])$/i, 'i\1es')
          inflect.plural(/ó([sn])$/i, 'o\1es')
          inflect.plural(/ú([sn])$/i, 'u\1es')
          inflect.singular(/s$/, '')
          inflect.singular(/es$/, '')
          inflect.irregular('el', 'los')
        'ley'.pluralize(:es)   # => "leyes"
        'ley'.pluralize(:en)   # => "leys"
        'avión'.pluralize(:es) # => "aviones"
        'avión'.pluralize(:en) # => "avións"
    A multilingual Inflector should be of use to anybody that is tasked with
    internationalizing their Rails application.
    Signed-off-by: David Celis <>
Commits on Jul 24, 2012
  1. @rafaelfranca

    Merge pull request #6991 from frodsan/performance_test_generator

    rafaelfranca authored
    update performance test template to use test method
Commits on Jul 23, 2012
  1. @spastorino

    Remove ActionDispatch::Head middleware in favor of Rack::Head

    spastorino authored
    Closes #7110 there's more work to do on rack-cache issue 69
Commits on Jul 21, 2012
  1. @rafaelfranca
Commits on Jul 19, 2012
  1. @tenderlove

    adding Rails::Queueing::Container

    tenderlove authored
    This allows us to do:
    In your configuration:
    Rails.queue[:image_queue] =
    Rails.queue[:mail_queue]  =
    In your app code:
    Both jobs pushed to the same default queue
Commits on Jul 18, 2012
  1. @lexmag
  2. @carlosgaldino

    Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` option

    carlosgaldino authored
    This applies to the following helpers:
  3. @josevalim

    Merge pull request #7028 from lexmag/join_table_indexes

    josevalim authored
    Add indexes to create_join_table method
Commits on Jul 17, 2012
  1. @lexmag

    Add join table migration generator

    lexmag authored
    For instance, running
        rails g migration CreateMediaJoinTable artists musics:uniq
    will create a migration with
        create_join_table :artists, :musics do |t|
          # t.index [:artist_id, :music_id]
          t.index [:music_id, :artist_id], unique: true
Commits on Jul 16, 2012
  1. A more informative comment for config.asset.debug

    Jared Beck authored
Commits on Jul 8, 2012
  1. @carlosantoniodasilva

    Rename RouteInspector to RoutesInspector

    carlosantoniodasilva authored
    Follow the consistency defined in dbc43bc.
  2. @carlosantoniodasilva

    Remove RoutesInspector from railties, since it was moved to AP

    carlosantoniodasilva authored
    Changes introduced in 7404cda.
    Fix railties build.
Commits on Jul 7, 2012
  1. @mattt @schneems

    move route_inspector to actionpack

    mattt authored schneems committed
    this is so we can show route output in the development when we get a routing error. Railties can use features of ActionDispatch, but ActionDispatch should not depend on Railties.
  2. @vijaydev
Commits on Jul 6, 2012
  1. update test_help to config properly turn natural language option

    Francesco Rodriguez authored
    Last versions of Turn don't monkey patch MiniTest to setup
    the natural language option. Here is an
    This patches the following behaviour:
        $ rake test:units
        `<top (required)>': undefined method `use_natural_language_case_names='
        for MiniTest::Unit:Class (NoMethodError)
  2. update performance test template to use test method

    Francesco Rodriguez authored
Commits on Jul 5, 2012
  1. @josevalim

    Merge pull request #6959 from robin850/patch-1

    josevalim authored
    Add few information on the field types
  2. @guilleiguaran
Commits on Jul 4, 2012
  1. @robin850
  2. @morgoth
Something went wrong with that request. Please try again.