Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Nov 7, 2011
  1. @luckydev
Commits on Nov 5, 2011
  1. @jonleighton

    Revert "Merge pull request #2378 from cesario/remove_warnings_activem…

    jonleighton authored
    This reverts commit 6aaae3d, reversing
    changes made to fdbc4e5.
    Reason: build failure.
  2. @vijaydev

    Merge pull request #2378 from cesario/remove_warnings_activemodel

    vijaydev authored
    Remove warnings by calling remove_method
Commits on Nov 4, 2011
  1. @franckverrot
  2. @jonleighton

    Convert CHANGELOGs to Markdown format.

    jonleighton authored
     * Markdown reads well as plain text, but can also be formatted.
     * It will make it easier for people to read on the web as Github
       formats the Markdown nicely.
     * It will encourage a level of consistency when people are writing
       CHANGELOG entries.
    The script used to perform the conversion is at
Commits on Oct 26, 2011
  1. @bradrobertson
Commits on Oct 20, 2011
  1. @vijaydev
Commits on Oct 19, 2011
  1. @martinsvalin
  2. @martinsvalin

    New #added? method on ActiveModel::Errors

    martinsvalin authored
    The #added? method makes it possible to check if a specific error has been added, using the same parameters as for #add.
Commits on Oct 17, 2011
  1. @vijaydev

    use variables from test setup

    vijaydev authored
  2. @vijaydev
  3. @martinsvalin
Commits on Oct 14, 2011
  1. @vijaydev
Commits on Oct 11, 2011
  1. @zhengjia
  2. @dolzenko
Commits on Oct 7, 2011
  1. @ugisozols
Commits on Oct 5, 2011
  1. @vijaydev
  2. @bobbytables
Commits on Oct 4, 2011
  1. @bobbytables
Commits on Sep 30, 2011
  1. @josevalim
  2. @nhocki

    Fixing `as_json` method for ActiveRecord models.

    nhocki authored
    When you've got an AR Model and you override the `as_json` method,
    you should be able to add default options to the renderer, like this:
        class User < ActiveRecord::Base
          def as_json(options = {})
            super(options.merge(:except => [:password_digest]))
    This was not possible before this commit. See the added test case.
Commits on Sep 29, 2011
  1. @ugisozols
Commits on Sep 26, 2011
  1. @jonleighton

    Make serializable_hash take attr values directly from attributes hash.

    jonleighton authored
    Previously, it would use send() to get the attribute. In Active
    Resource, this would rely on hitting method missing. If a method with
    the same name was defined further up the ancestor chain, that method
    would wrongly be called.
    This change fixes test_to_xml_with_private_method_name_as_attribute in
    activeresource/test/cases/base_test.rb, which was broken after
    51bef9d, because that change made
    to_xml use serializable_hash.
Commits on Sep 22, 2011
  1. @josevalim

    Refactor AMo as_json.

    josevalim authored
  2. @mattetti

    fixed a bug with the json serialization when the class setting is set…

    mattetti authored
    … to not include the root, but an instance is serialized with the root option passed as true
Commits on Sep 18, 2011
  1. @josevalim
Commits on Sep 14, 2011
  1. @vijaydev
Commits on Sep 13, 2011
  1. @jonleighton

    Generate attribute method unless it's already in the module.

    jonleighton authored
    There's no harm in generating a method name that's already defined on
    the host class, since we're generating the attribute methods in a module
    that gets included. In fact, this is desirable as it allows the host
    class to call super.
Commits on Sep 12, 2011
  1. @jonleighton

    Add an attribute_missing method to ActiveModel::AttributeMethods.

    jonleighton authored
    This can be overloaded by implementors if necessary.
  2. @jonleighton

    Avoid double super call in some cases.

    jonleighton authored
    If super was false earlier, it is still going to be false, so we don't
    need to call it again at the end of the method.
  3. @jonleighton

    Let Ruby deal with method visibility.

    jonleighton authored
    Check respond_to_without_attributes? in method_missing. If there is any
    method that responds (even private), let super handle it and raise
    NoMethodError if necessary.
  4. @jonleighton
  5. @jonleighton


    jonleighton authored
  6. @jonleighton

    Use an empty AttributeMethodMatcher by default.

    jonleighton authored
    This means that attribute methods which don't exist will get generated
    when define_attribute_methods is called, so we don't have to use hacks
    like `attribute_method_suffix ''`.
Commits on Sep 9, 2011
  1. @lawrencepit
Something went wrong with that request. Please try again.