Permalink
Switch branches/tags
Commits on Jul 12, 2018
  1. Merge pull request #33341 from Edouard-chin/ec-fix-to-param

    rafaelfranca committed Jul 12, 2018
    e4e1b62 broke `to_param` handling:
Commits on Jun 13, 2018
  1. Merge pull request #33125 from bogdanvlviv/fix-test_deprecated_body_s…

    kamipo committed Jun 13, 2018
    …tream
    
    Fix test `TestCaseTest#test_deprecated_body_stream`
Commits on Jun 12, 2018
  1. Fix test `TestCaseTest#test_deprecated_body_stream`

    bogdanvlviv committed Jun 12, 2018
    It fails since e8a9499
    
    https://travis-ci.org/rails/rails/jobs/391059004#L1779-L1788
    
    ```
    Failure:
    TestCaseTest#test_deprecated_body_stream [/work/rails/actionpack/test/controller/test_case_test.rb:245]:
    --- expected
    +++ actual
    @@ -1 +1 @@
    -"page%5Bname%5D=page+name&some+key=123"
    +"page[name]=page+name&some+key=123"
    ```
  2. Merge pull request #33093 from rails/use-rack-to-dump-query

    tenderlove committed Jun 11, 2018
    Use Rack to generate query information under test
Commits on Jun 5, 2018
  1. Merge pull request #33025 from bkuhlmann/reverse_sql_order_patch-50

    tenderlove committed Jun 5, 2018
    Fixed `reverse_order` Arel SQL literal issue.
Commits on May 30, 2018
  1. Fixed `reverse_order` Arel SQL literal issue.

    bkuhlmann committed May 30, 2018
    Use `<<` instead of `concat` in `reverse_sql_order` as we can have an
    Arel SQL literator which overrides `concat`.
Commits on May 23, 2018
  1. Merge pull request #32875 from rails/backport-cast-type

    tenderlove committed May 23, 2018
    Avoid type casting in uniqueness validator
  2. Avoid type casting in uniqueness validator

    kamipo authored and tenderlove committed Apr 26, 2016
    Type casting in uniqueness validator is for a string value truncation.
    It was removed at #23523.
Commits on May 11, 2018
  1. Merge pull request #32871 from tarebyte/backport-update_attribute

    tenderlove committed May 11, 2018
    Backport "save attributes changed by callbacks after update_attribute"
Commits on Apr 10, 2018
  1. Merge pull request #32513 from bogdanvlviv/update-bug_report_template…

    kamipo committed Apr 10, 2018
    …s-on-5-0-stable
    
    [5-0-stable] Update bug report templates
  2. [5-0-stable] Update bug report templates

    bogdanvlviv committed Apr 10, 2018
    Set Rails 5.0.7 in templates
  3. Merge pull request #32506 from bogdanvlviv/5-0-stable-fix-test

    rafaelfranca committed Apr 10, 2018
    [5-0-stable] Improve `TestCaseTest#test_request_format_kwarg_doesnt_mutate_params`
Commits on Apr 9, 2018
  1. [5-0-stable] Improve `TestCaseTest#test_request_format_kwarg_doesnt_m…

    bogdanvlviv committed Apr 9, 2018
    …utate_params`
    
    Use `#freeze` in order to express that params don't mutate.
    
    Related to #32492
Commits on Apr 8, 2018
  1. Merge pull request #32492 from eugeneius/dont_mutate_parameters

    pixeltrix committed Apr 8, 2018
    [5-0-stable] Don't mutate parameters in test request helpers
Commits on Apr 7, 2018
  1. Don't mutate parameters in test request helpers

    eugeneius committed Apr 7, 2018
    Mutating the value passed as the `params` keyword argument when making
    a request in a controller test is surprising behaviour. We can avoid it
    by calling `symbolize_keys` first, which will make a copy of the hash.
    
    This matches the behaviour on 5.1 and later, which was introduced in
    98b8309. On 4.2 and earlier, passing
    `format` separately wasn't supported, so this fix is only needed on 5.0.
Commits on Apr 6, 2018
  1. Merge pull request #32473 from yujideveloper/fix/load-issue-of-am-mes…

    rafaelfranca committed Apr 6, 2018
    …sage-delivery
    
    Fix loading issue of `ActionMailer::MessageDelivery`
Commits on Apr 3, 2018
  1. Update sidekiq

    pixeltrix committed Apr 3, 2018
    Sidekiq 5.1.3 fixes the version check on Ruby 2.2.10.
Commits on Apr 2, 2018
  1. Lock Sidekiq for < 5 for Ruby 2.2

    pixeltrix committed Apr 2, 2018
    Sidekiq has a version check error for Ruby 2.2.10.
  2. Update Gemfile.lock

    pixeltrix committed Apr 2, 2018
  3. Backport fix for Dir::Tmpname.create from #32386

    pixeltrix committed Apr 2, 2018
    The removal of path separators from the tmpname value affects all four
    supported versions of Ruby - 2.2.10, 2.3.7, 2.4.4, and 2.5.1.
Commits on Mar 29, 2018
Commits on Mar 24, 2018
  1. Fix test for mysql2 gem spec in generated Gemfile

    pixeltrix committed Mar 24, 2018
  2. Support mysql2 0.4.x and 0.5.x

    sodabrew authored and pixeltrix committed Mar 21, 2018
Commits on Mar 21, 2018
Commits on Mar 19, 2018
  1. Fix failing `QuotingTest#test_quoted_time_utc`

    bogdanvlviv authored and pixeltrix committed Mar 18, 2018
    This test fails in specific time.
    Example:
    
    If run this test on the machine with time 01:00 am UTC+2,
    this test will fail.
    Changing representing of 2000-01-01 01:00 am UTC+2 to UTC+0 change
    the day, month and even year in our case,
    so substitution `"2000-01-01 "` to `""` isn't possible.
    
    ```
    Failure:
    ActiveRecord::ConnectionAdapters::QuotingTest#test_quoted_time_utc
    Expected: "1999-12-31 23:01:27"
      Actual: "23:01:27"
    ```
    
    Related to 7c479cb