Permalink
Switch branches/tags
Commits on Oct 14, 2018
  1. Merge pull request #34209 from y-yagi/fix_tests_on_mail_271

    y-yagi committed Oct 14, 2018
    Fix tests on Mail 2.7.1
Commits on Oct 12, 2018
  1. Ensure that `ids_reader` respects dirty target whether target is load…

    kamipo committed Apr 21, 2018
    …ed or not
    
    Currently `ids_reader` doesn't respect dirty target when the target is
    not loaded yet unlike `collection.size`. I believe the inconsistency is
    a bug, fixes the `ids_reader` to behave consistently regardless of
    whether target is loaded or not.
Commits on Oct 10, 2018
  1. Merge pull request #34122 from kamipo/generate_relation_methods

    kamipo committed Oct 10, 2018
    Generate delegation methods to named scope in the definition time
Commits on Oct 9, 2018
  1. Fix directly uploading using a MIME type synonym

    georgeclaghorn committed Oct 8, 2018
    When Content-Type is "application/x-gzip", request.content_type resolves to "application/gzip", because application/x-gzip is a synonym of application/gzip by default. This causes the acceptable_content? check in ActiveStorage::DiskController to fail, because the direct upload token contains application/x-gzip, which is not equal to application/gzip.
    
    Fix by comparing the token content type with the request content type *and its synonyms*.
Commits on Oct 7, 2018
  1. Merge pull request #34101 from gmcgibbon/fix_bundler_1_16_6_test_fail…

    rafaelfranca authored and kamipo committed Oct 5, 2018
    …ures
    
    Remove bundler warnings from bin/setup output
  2. Fix `AssociationRelation` not to set inverse instance key just like b…

    kamipo committed Oct 7, 2018
    …efore
    
    Since #31575, `set_inverse_instance` replaces the foreign key by the
    current owner immediately to make it happen when a record is added to
    collection association.
    
    But `set_inverse_instance` is not only called when a record is added,
    but also when a record is loaded from queries. And also, that loaded
    records are not always associated records for some reason (using `or`,
    `unscope`, `rewhere`, etc).
    
    It is hard to distinguish whether or not we should invoke
    `set_inverse_instance`, but at least we should avoid the undesired
    side-effect which was brought from #31575.
    
    Fixes #34108.
  3. Merge pull request #34114 from Madogiwa0124/update_getting_start_rail…

    eileencodes committed Oct 7, 2018
    …s_version
    
    getting started page rails version update to 5.2.1
Commits on Oct 5, 2018
  1. Bugfix: ActiveSupport::EncryptedConfiguration reading of comment-only…

    spickermann authored and y-yagi committed Oct 4, 2018
    … encrypted files (#34014)
    
    * Fix reading comment only encrypted files
    
    When a encrypted file contains only comments then reading that files raises an error:
    
        NoMethodError: undefined method `deep_symbolize_keys' for false:FalseClass
            activesupport/lib/active_support/encrypted_configuration.rb:33:in `config'
            test/encrypted_configuration_test.rb:52:in `block in <class:EncryptedConfigurationTest>'
    
    This happens because the previous implementation returned a `{}` fallback for blank YAML strings. But it did not handle YAML strings that are present but still do not contain any _usefull_ YAML - like the file created by `Rails::Generators::EncryptedFileGenerator` which looks like this:
    
        # aws:
        #   access_key_id: 123
        #   secret_access_key: 345
    
    * Fix coding style violation
    
    * Add backwardscompatible with Psych versions that were shipped with Ruby <2.5
    
    * Do not rely on railties for Active Support test
    
    * Simplify error handling
    
    * Improve test naming
    
    * Simplify file creation in test
Commits on Sep 27, 2018
  1. Merge pull request #34002 from gmcgibbon/fix_deeply_nested_scoped_root

    rafaelfranca committed Sep 27, 2018
    Fix optionally scoped root route unscoped access
Commits on Sep 23, 2018
Commits on Sep 22, 2018
  1. Revert "Merge pull request #33943 from schneems/schneems/recyclable-c…

    rafaelfranca committed Sep 22, 2018
    …ach-keys-52"
    
    This reverts commit 130614a, reversing
    changes made to 1a3f963.
    
    This is a breaking change even for stores that supports the new schema.
    Since they don't implement `supports_cache_versioning?` they will now
    start to fail where they would just work before.
Commits on Sep 21, 2018
  1. Switch to supports_cache_versioning? check to a class method

    schneems committed Sep 21, 2018
    - Moving the `supports_cache_versioning?` check to a class method. 
    - Shorten the method doc. 
    - Expand on the error message.
  2. [close #33907] Error when using "recyclable" cache keys with a store …

    schneems committed Sep 20, 2018
    …that does not support it
    
    If you are using the "in cache versioning" also known as "recyclable cache keys" the cache store must be aware of this scheme, otherwise you will generate cache entries that never invalidate.
    
    This PR adds a check to the initialization process to ensure that if recyclable cache keys are being used via
    
    ```
    config.active_record.cache_versioning = true
    ```
    
    Then the cache store needs to show that it supports this versioning scheme. Cache stores can let Rails know that they support this scheme by adding a method `supports_in_cache_versioning?` and returning true.
Commits on Sep 20, 2018
  1. Merge pull request #33850 from sharang-d/fix-asset_enqueued_with-for-…

    rafaelfranca committed Sep 20, 2018
    …hashes
    
    Make sure `assert_enqueued_with()` & `assert_performed_with()` work reliably with hash arguments
  2. Merge pull request #33891 from jgorman/remote_names

    rafaelfranca committed Sep 20, 2018
    Contributing to Ruby on Rails Guide: standardize git remote names [ci skip].
  3. Merge pull request #33925 from rafaelfranca/rm-fix-column_defaults

    sgrif authored and rafaelfranca committed Sep 20, 2018
    Make a deep copy of the _default_attributes in column_defaults
Commits on Sep 19, 2018
  1. Don't return the same object when using find with an empty array

    rafaelfranca committed Sep 19, 2018
    When you pass an empty array to find we know we shoudl return an empty
    array but it is surprising that we are returning the original empty
    array instead of a new one.
Commits on Sep 17, 2018
  1. Merge pull request #33902 from bogdanvlviv/related-to-31727

    kamipo committed Sep 17, 2018
    Fix deprecation warning of `ActiveRecord::Migrator.migrations_path=`
  2. Merge pull request #33188 from larskanis/pg-1.1

    y-yagi committed Sep 16, 2018
    PostgreSQL: prepare for pg-1.1
  3. Merge pull request #33899 from bogdanvlviv/follow-up-33405

    georgeclaghorn committed Sep 17, 2018
    Raise `ActiveRecord::InvalidForeignKey` in `before_destroy` for a blob if attachments exist
Commits on Sep 15, 2018
  1. Merge pull request #33878 from kamipo/fallback_to_unprepared_statement

    kamipo committed Sep 15, 2018
    Fallback to unprepared statement only when bind params limit is exceeded
Commits on Sep 13, 2018
  1. Merge pull request #33174 from thomasdziedzic-pd/backport-documentati…

    rafaelfranca committed Sep 13, 2018
    …on-fixes
    
    Backport documentation fixes
  2. Merge pull request #33844 from kamipo/too_many_eager_load_ids

    kamipo committed Sep 13, 2018
    Eager loading/preloading should be worked regardless of large number of records
Commits on Sep 12, 2018
  1. Merge pull request #33856 from eileencodes/fix-query-cache-to-load-be…

    eileencodes committed Sep 12, 2018
    …fore-first-request
    
    Fix query cache to load before first request
  2. Merge pull request #33483 from DylanReile/master

    rafaelfranca committed Sep 12, 2018
    Disable content security policy for mailer previews
Commits on Sep 11, 2018
  1. Merge pull request #33795 from marceloperini/marceloperini/33450-acti…

    rafaelfranca committed Sep 11, 2018
    …ve-storage
    
    Fix zero-byte files upload in #33630
  2. Merge pull request #33804 from yskkin/num_string

    kamipo committed Sep 7, 2018
    Fix non_numeric_string?
  3. Merge pull request #33639 from darwin67/33610-duplicated-nested-recor…

    kamipo committed Sep 11, 2018
    …ds-with-create_with
    
    Make sure there are no duplicated nested records with create_with
Commits on Sep 10, 2018
  1. Use canonical name for block local

    y-yagi committed Sep 6, 2018
    `spec` is the same variable name as gemspec generated by bundler, and its
    intention is easier to understand than a one-letter variable.
    https://github.com/bundler/bundler/blob/00fd58eaa69015092ee272c4cb5aa92a5e7ee45c/lib/bundler/templates/newgem/newgem.gemspec.tt#L11
    
    This is follow up 685cf0d. `spec` is already in use there.
Commits on Sep 6, 2018
  1. Generate a gem that can't be pushed to Rubygems.org by default

    rafaelfranca committed Sep 6, 2018
    This will avoid gems that are made to be private to be pushed to public
    repositories.
  2. Merge pull request #33574 from lsylvester/change-i18n-defaults-behavi…

    rafaelfranca committed Sep 6, 2018
    …our-to-match-i18n-1.1.0
    
    update I18n fallbacks configuration to be compatible with i18n 1.1.0