Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 18, 2012
  1. @kennyj @carlosantoniodasilva
Commits on Jun 10, 2012
  1. @josevalim

    Merge pull request #6665 from schneems/schneems/raise-migration-error

    josevalim authored
    Notify A User they Have Pending Migrations
Commits on Jun 9, 2012
  1. @schneems

    raise error for pending migration

    schneems authored
    can be configured by setting config.active_record.migration. Setting to :page_load will raise an error on each page refresh if there are migrations that are pending. Setting to :page_load is defaulted in development for new applications.
Commits on Jun 6, 2012
  1. change AMS::JSON.include_root_in_json default value to false

    Francesco Rodriguez authored
    Changes:
    
    * Update `include_root_in_json` default value to false for default value
      to false for `ActiveModel::Serializers::JSON`.
    * Remove unnecessary change to include_root_in_json option in
      wrap_parameters template.
    * Update `as_json` documentation.
    * Fix JSONSerialization tests.
    
    Problem:
    
    It's confusing that AM serializers behave differently from AR,
    even when AR objects include AM serializers module.
    
        class User < ActiveRecord::Base; end
    
        class Person
          include ActiveModel::Model
          include ActiveModel::AttributeMethods
          include ActiveModel::Serializers::JSON
    
          attr_accessor :name, :age
    
          def attributes
            instance_values
          end
        end
    
        user.as_json
        => {"id"=>1, "name"=>"Konata Izumi", "age"=>16, "awesome"=>true}
        # root is not included
    
        person.as_json
        => {"person"=>{"name"=>"Francesco", "age"=>22}}
        # root is included
    
        ActiveRecord::Base.include_root_in_json
        => false
    
        Person.include_root_in_json
        => true
    
        # different default values for include_root_in_json
    
    Proposal:
    
    Change the default value of AM serializers to false, update
    the misleading documentation and remove unnecessary change
    to false of include_root_in_json option with AR objects.
    
        class User < ActiveRecord::Base; end
    
        class Person
          include ActiveModel::Model
          include ActiveModel::AttributeMethods
          include ActiveModel::Serializers::JSON
    
          attr_accessor :name, :age
    
          def attributes
            instance_values
          end
        end
    
        user.as_json
        => {"id"=>1, "name"=>"Konata Izumi", "age"=>16, "awesome"=>true}
        # root is not included
    
        person.as_json
        => {"name"=>"Francesco", "age"=>22}
        # root is not included
    
        ActiveRecord::Base.include_root_in_json
        => false
    
        Person.include_root_in_json
        => false
    
        # same behaviour, more consistent
    
    Fixes #6578.
Commits on May 22, 2012
  1. @gaurish

    Move root method at TOP of routes file

    gaurish authored
    Made the change as per the following text in routing guide:-
    "You should put the root route at the top of the file,
    because it is the most popular route and should be matched first."
    
    However, if root is best left at bottom. We will change to fix that text
Commits on May 14, 2012
  1. @josevalim
Commits on May 13, 2012
  1. @korny
Commits on May 12, 2012
  1. @rafaelfranca
  2. @vijaydev

    s/wether/whether [ci skip]

    vijaydev authored
  3. @homakov
Commits on Apr 28, 2012
  1. @josevalim

    Use Rails::Queueing::Queue instead of Queue so people can build their…

    josevalim authored
    … own consumers around stdlib's Queue
Commits on Apr 27, 2012
  1. @wycats

    Initial queue implementation

    wycats authored
Commits on Apr 25, 2012
  1. @jeremy
Commits on Apr 24, 2012
  1. @homakov
Commits on Apr 16, 2012
  1. @rosenfeld

    Make log_level explicit in production.rb template

    rosenfeld authored
    The 'production' environment name is currently checked for setting up
    the default log_level to 'info' but that won't work if the environment
    is copied to staging.rb, for instance. Better to have it explicitly set.
Commits on Apr 11, 2012
  1. @vijaydev

    copy editing [ci skip]

    vijaydev authored
Commits on Apr 8, 2012
  1. @gaurish
Commits on Mar 28, 2012
  1. @andhapp
Commits on Mar 14, 2012
  1. @josevalim

    Remove --http.

    josevalim authored
  2. @carlosantoniodasilva @spastorino

    Rename http-only app generator option to http

    carlosantoniodasilva authored spastorino committed
    [Carlos Antonio da Silva & Santiago Pastorino]
  3. @carlosantoniodasilva @spastorino

    Generate middleware http_only! config when running http only app gene…

    carlosantoniodasilva authored spastorino committed
    …rator
    
    [Carlos Antonio da Silva & Santiago Pastorino]
  4. @spastorino

    Add ActionController::HTTP

    spastorino authored
    More info http://edgeguides.rubyonrails.org/api_app.html
    
    [Carlos Antonio da Silva & Santiago Pastorino]
  5. @rafaelfranca

    Remove key_value helper now that master is 1.9 only and we always use

    rafaelfranca authored
    the 1.9 hash syntax in the generators.
Commits on Mar 13, 2012
  1. @guilleiguaran
  2. @sikachu

    Remove Active Resource source files from the repository

    sikachu authored
    Dear Active Resource,
    
    It's not that I hate you or anything, but you didn't get much attention lately. There're so many alternatives out there, and I think people have made their choice to use them than you. I think it's time for you to have a big rest, peacefully in this Git repository.
    
    I will miss you,
    
    @sikachu.
  3. @vijaydev
Commits on Mar 12, 2012
  1. @tenderlove

    allow people to specify custom formatters, use the default formatter …

    tenderlove authored
    …in production so that PID and timestamp are logged. fixes #5388
  2. @filipeamoreira
Commits on Mar 7, 2012
  1. @fxn

    Revert "let the connection pool of new applications have size 1 rathe…

    fxn authored
    …r than 5"
    
    Reason: Temporarily reverting this because it has uncovered an issue that
    prevents Sam's test suite from passing.
    
    This reverts commit 9b2c38b.
Commits on Mar 5, 2012
  1. @rafaelfranca
Commits on Mar 4, 2012
  1. @NZKoz

    Whitelist all attribute assignment by default.

    NZKoz authored
    Change the default for newly generated applications to whitelist all attribute assignment.  Also update the generated model classes so users are reminded of the importance of attr_accessible.
Commits on Feb 26, 2012
  1. @fxn

    let the connection pool of new applications have size 1 rather than 5

    fxn authored
    The majority of Rails applications are multiprocess, people
    may wonder why rails new generates a default pool of 5, does
    my application need a connection pool of 5? By generating
    a default of 1 database.yml is much more clear, and with
    the comment people know what is the connection pool for,
    and they know it has to be bigger for multithread apps.
Commits on Feb 25, 2012
  1. @fxn

    uses PATCH for the forms of persisted records, and routes PATCH and P…

    fxn authored
    …UT to the update action of resources
Commits on Feb 24, 2012
  1. @fxn

    removes the reconnect key from the database.yml generated for MySQL

    fxn authored
    The reconnect flag does not play nicely with transactions and so
    it is of little use in Rails applications. Thus, albeit supported
    by mysql2, it does not deserve such a prominent place in the
    generated database.yml, which should be a representative config
    example. Note that the flag is false by default.
    
    Advanced users know from mysql2 docs that the flag is available.
  2. @fxn
Something went wrong with that request. Please try again.