Permalink
Switch branches/tags
Commits on Oct 5, 2012
  1. Merge pull request #7838 from guilleiguaran/extract-rack-cache

    spastorino committed Oct 5, 2012
    Disable Rack::Cache by default
Commits on Oct 4, 2012
  1. Use String#exclude? to make sure that Active Support is not loaded when

    rafaelfranca committed Oct 4, 2012
    bare is true.
    
    We need to change this since coffee-rails loads ActionView that loads
    core_ext/array/access.
  2. Remove unneeded CHANGELOG entry.

    rafaelfranca committed Oct 4, 2012
    This was added in Rails 4 and we don't need changelog entries to
    behavior changes
    
    [ci skip]
  3. Merge pull request #7847 from bloudermilk/recursive_permit

    dhh committed Oct 4, 2012
    ActionController::Parameters#permit! is recursive
  4. Do not set removed option

    rafaelfranca committed Oct 4, 2012
    Sine page caching was remove from the core we don't have the
    page_cache_directory anymore
  5. Merge pull request #7833 from frodsan/extract_ap_pages_actions_caching

    rafaelfranca committed Oct 4, 2012
    Extract AP Page and Action caching from Rails
  6. Merge pull request #7846 from ahaymond/master

    rafaelfranca committed Oct 4, 2012
    Updated comments for [ci skip]
  7. Update activerecord/lib/active_record/persistence.rb

    AHaymond committed Oct 4, 2012
    - Changed the comments documentation for the update_column(s) methods to add a little bit of clarity
  8. add an entry about AP page and action extraction in the upgrading gui…

    Francesco Rodriguez
    Francesco Rodriguez committed Oct 4, 2012
    …de [ci skip]
  9. Merge pull request #7769 from rgarver/feature/public-fragment_name_wi…

    dhh committed Oct 4, 2012
    …th_digest
    
    Move the CacheHelper#fragment_name_with_digest to be public
  10. Merge pull request #6978 from frodsan/count_nosql_unsaved_parent

    rafaelfranca committed Oct 4, 2012
    Count returns 0 without querying if parent is not saved
Commits on Oct 3, 2012
  1. Count returns 0 without querying if parent is not saved

    Francesco Rodriguez
    Francesco Rodriguez committed Oct 3, 2012
    Patches `CollectionAssociation#count` to return 0 without querying
    if the parent record is new. Consider the following code:
    
        class Account
          has_many :dossiers
        end
    
        class Dossier
          belongs_to :account
        end
    
        a = Account.new
        a.dossiers.build
    
        # before patch
        a.dossiers.count
        # SELECT COUNT(*) FROM "dossiers" WHERE "dossiers"."account_id" IS NULL
        # => 0
    
        # after
        a.dosiers.count # fires without sql query
        # => 0
    
    Fixes #1856.
  2. rename page_cache_extension option to default_static_extension

    Francesco Rodriguez
    Francesco Rodriguez committed Oct 3, 2012
  3. Refactor

    spastorino committed Oct 3, 2012
  4. Use the `flat_map` method.

    rafaelfranca committed Oct 3, 2012
    Thanks to @jeremy to teach me this one.
  5. Revert "Merge pull request #7826 from sikachu/master-validators-kind"

    rafaelfranca committed Oct 3, 2012
    This reverts commit 4e9f53f, reversing
    changes made to 6b802cd.
    
    Revert "Don't use tap in this case."
    
    This reverts commit 454d820.
    
    Reason: Is not a good idea to add options to this method since we can do
    the same thing using method composition.
    
        Person.validators_on(:name).select { |v| v.kind == :presence }
    
    Also it avoids to change the method again to add more options.
  6. Don't use tap in this case.

    rafaelfranca committed Oct 3, 2012
    The use of tap in this case is very confusing since we are mutating the
    return value inside the block
  7. Merge pull request #7826 from sikachu/master-validators-kind

    rafaelfranca committed Oct 3, 2012
    Make `.validators_on` accept `:kind` option
  8. Make `.validators_on` accept `:kind` option

    sikachu committed Oct 3, 2012
    This will filter out the validators on a particular attribute based on
    its kind.
  9. Merge pull request #7825 from sikachu/master-rails-pathname

    rafaelfranca committed Oct 3, 2012
    Make Rails.public_path return a Pathname