Skip to content
Commits on Aug 7, 2012
  1. @rafaelfranca

    Deprecate `button_to_function` and `link_to_function` helpers.

    We recommend the use of Unobtrusive JavaScript instead. For example:
    
      link_to "Greeting", "#", :class => "nav_link"
    
      $(function() {
        $('.nav_link').click(function() {
          // Some complex code
    
          return false;
        });
      });
    
    or
    
      link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link"
    
    for simple cases.
    
    This reverts commit 3acdd65.
    rafaelfranca committed Aug 7, 2012
  2. @dhh

    Remove antiquated example code

    dhh committed Aug 7, 2012
  3. @dhh
  4. @dhh

    Observers are no longer important enough to get this configuration op…

    …tion called out at the top level
    dhh committed Aug 7, 2012
  5. @rafaelfranca

    Add back missing require

    rafaelfranca committed Aug 7, 2012
  6. @rafaelfranca
  7. @rafaelfranca

    Deprecate ActiveSupport::JSON::Variable

    Reason: ActiveSupport::JSON::Variable is not used anymore internally. It
    was deprecated in 3-2-stable but we reverted all the deprecation for
    point releases.
    
    See #6536 and #6546.
    Conflicts:
    	activesupport/lib/active_support/json/variable.rb
    Erich Menge committed with rafaelfranca May 30, 2012
  8. @tenderlove
  9. @josevalim

    Revert "Merge pull request #7202 from asanghi/perform_deliveries_in_m…

    …ail"
    
    Reverting because it feels backward to specify a delivery to not
    be performed while the e-mail is being composed. It is simpler (and
    makes more sense) to delegate the responsibility to the calling code.
    josevalim committed Aug 7, 2012
  10. @dhh

    Revert "Merge pull request #7033 from kron4eg/master". Not a a fan at…

    … all of what this makes ERB files look like.
    
    This reverts commit 46b8bce, reversing
    changes made to 2f58795.
    dhh committed Aug 7, 2012
  11. @dhh

    Revert "The application generator generates `public/humans.txt` with …

    …some basic data". I dont consider this something most people is going to want most of the time. If you want to add it in your own app, knock yourself out. But it doesnt belong in Rails imo
    dhh committed Aug 7, 2012
  12. @spastorino

    Merge pull request #7033 from kron4eg/master

    Restore "%" ERb/Erubis Trim Mode
    spastorino committed Aug 7, 2012
  13. @fxn
  14. @kron4eg

    Restoring the '%' trim mode for ERb templates, allowing for a leading…

    … percent sign on a line to indicate non-inserted Ruby code.
    kron4eg committed Jul 11, 2012
Commits on Aug 6, 2012
  1. @rafaelfranca

    Merge pull request #7277 from sikachu/master-js-include-tag-fix

    Do not include application.js if it doesn't exists
    rafaelfranca committed Aug 6, 2012
  2. @sikachu
  3. @sikachu

    Do not include application.js if it doesn't exists

    Rails were including 'application.js' to the pack when using
    `javascript_include_tag :all` even there's no application.js in the
    public directory.
    sikachu committed Aug 6, 2012
  4. @rafaelfranca
  5. @asanghi

    add changelog for #7202

    asanghi committed Aug 7, 2012
  6. @rafaelfranca

    Merge pull request #7272 from lexmag/string_inquirer

    Add AS::StringInquirer#respond_to? method
    rafaelfranca committed Aug 6, 2012
  7. @tenderlove
  8. @lexmag

    Add AS::StringInquirer#respond_to? method

    Consistently with #method_missing
    lexmag committed Aug 5, 2012
  9. @rafaelfranca
  10. @rafaelfranca
Commits on Aug 5, 2012
  1. @rafaelfranca

    Merge pull request #7140 from seamusabshere/patch-1

    Make sure :environment task is executed before db:schema:load or
    db:structure:load
    rafaelfranca committed Aug 5, 2012
  2. @rafaelfranca

    Update changelog

    rafaelfranca committed Aug 5, 2012
  3. @fxn

    removes usage of Object#in? from the code base (the method remains de…

    …fined by Active Support)
    
    Selecting which key extensions to include in active_support/rails
    made apparent the systematic usage of Object#in? in the code base.
    After some discussion in
    
        5ea6b0d
    
    we decided to remove it and use plain Ruby, which seems enough
    for this particular idiom.
    
    In this commit the refactor has been made case by case. Sometimes
    include? is the natural alternative, others a simple || is the
    way you actually spell the condition in your head, others a case
    statement seems more appropriate. I have chosen the one I liked
    the most in each case.
    fxn committed Aug 6, 2012
  4. @jonleighton

    Merge pull request #7270 from beerlington/use_exists_for_empty

    Changing AR:CollectionAssociation#empty? to use #exists?
    jonleighton committed Aug 5, 2012
  5. @beerlington

    Changing AR:CollectionAssociation#empty? to use #exists?

    COUNT(*) queries can be slow in PostgreSQL, #exists? avoids this by
    selecting a single record.
    beerlington committed Aug 5, 2012
  6. @rafaelfranca

    Merge pull request #7268 from arunagw/warning-removed-small

    Remove warning: `*' interpreted as argument prefix
    rafaelfranca committed Aug 5, 2012
  7. @arunagw
Commits on Aug 4, 2012
  1. @pixeltrix

    Revert "polymorphic_url with an array generates a query string"

    Passing options as the last value in an array doesn't work with form_for.
    This reverts commit 61c8a4d.
    pixeltrix committed Aug 4, 2012
  2. @pixeltrix

    Revert "Refactor passing url options via array for polymorphic_url"

    Passing options as the last value in an array doesn't work with form_for.
    This reverts commit 6be564c.
    pixeltrix committed Aug 4, 2012
  3. @spastorino

    Merge pull request #7262 from bogdan/refator_route_set

    Refator route set
    spastorino committed Aug 4, 2012
  4. @bogdan
Something went wrong with that request. Please try again.